Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Rename Requires to AlphaRequires #862

Merged
merged 2 commits into from
May 17, 2017
Merged

Rename Requires to AlphaRequires #862

merged 2 commits into from
May 17, 2017

Conversation

pmorie
Copy link
Contributor

@pmorie pmorie commented May 16, 2017

Until we sort out #815.

@pmorie pmorie added the api label May 16, 2017
@pmorie pmorie added this to the 0.0.7 milestone May 16, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 16, 2017
@jpeeler jpeeler added the LGTM1 label May 16, 2017
@pmorie pmorie changed the title Alpha requires Rename Requires to AlphaRequires May 16, 2017
@kibbles-n-bytes kibbles-n-bytes added LGTM2 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 16, 2017
@pmorie pmorie removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2017
MHBauer
MHBauer approved these changes May 17, 2017
View reviewed changes
Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tightens the requirements for our api by making the coverage smaller by one field.

lgtm

@MHBauer MHBauer added the LGTM3 label May 17, 2017
@MHBauer MHBauer merged commit 85196f5 into kubernetes-retired:master May 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MHBauer MHBauer MHBauer approved these changes

Assignees
No one assigned
Labels
api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 LGTM3
Projects
None yet
Milestone
0.0.7
Development

Successfully merging this pull request may close these issues.
5 participants
@pmorie @MHBauer @jpeeler @kibbles-n-bytes @k8s-ci-robot