Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

How should we treat OSB tags? #497

Closed
pmorie opened this issue Mar 8, 2017 · 16 comments
Closed

How should we treat OSB tags? #497

pmorie opened this issue Mar 8, 2017 · 16 comments
Assignees
Labels
api broker-api-spec-compliance lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@pmorie
Copy link
Contributor

pmorie commented Mar 8, 2017

The OSB API provides tags, a list of strings, to do the type of filtering that kubernetes uses labels for. This issue is to determine if we should:

  1. Just use tags to do the type of search that CF does using tags
  2. Translate tags into label selectors somehow and use label selection
  3. Something else TBD

cc @jwforres

@pmorie pmorie added this to the MVP 2 milestone Mar 8, 2017
@jwforres
Copy link
Contributor

jwforres commented Mar 8, 2017

FYI @dtaylor113 @jeff-phillips-18 tags are how we would categorize and filter things

@pmorie pmorie modified the milestones: MVP 3, MVP 2 Mar 13, 2017
@pmorie
Copy link
Contributor Author

pmorie commented Apr 6, 2017

Moving to 0.0.3 because we will not get to it before then.

@pmorie pmorie modified the milestones: 0.0.3, 0.0.2 Apr 6, 2017
@arschles
Copy link
Contributor

Moving this into 0.1.0 since we will need to decide on OSB tags before we provide backward-compatibility guarantees by then

@duglin
Copy link
Contributor

duglin commented May 13, 2017

Since labels and annotations are name/value pairs, but tags are just strings it doesn't seem like there's a good spot put them on the kueb core resource model. This would seem to then imply that we're probably going to have to keep this info in our own property - like we have now. Its just too bad that we can't easily search over it with some native kube search facility. We should have a brief chat about this but I'd suggest we close this issue.

@pmorie
Copy link
Contributor Author

pmorie commented May 13, 2017 via email

@duglin
Copy link
Contributor

duglin commented May 13, 2017

true, that would be the super safe option for beta.

Haven't thought much about 'requires' yet - does anyone think it would ever be more than just an array of strings to us? I know at some point we'll need to look at it and perhaps do something (like reject a serviceClass if we don't support one of the "requires") but would we ever store it as something else?

@jwforres
Copy link
Contributor

Please do not remove tags completely, if you want to change it to an alpha field until you decide what to do long term that's fine.

@pmorie
Copy link
Contributor Author

pmorie commented May 15, 2017

I will open a PR to change the name of Tags to AlphaTags after #843 is merged

@arschles
Copy link
Contributor

We're moving all OSB* tags to alpha. Moving to 1.0.0

@arschles arschles modified the milestones: 1.0.0, 0.1.0 May 15, 2017
@duglin
Copy link
Contributor

duglin commented May 15, 2017

to be clear, its just one property "OSBTags" we're moving, not all OSB properties

@MHBauer
Copy link
Contributor

MHBauer commented Jun 8, 2018

This isn't closed by #861 or #1180. We still don't handle tags, but they're described as alpha.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2019
@jberkhahn jberkhahn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 20, 2019
@mszostok
Copy link
Contributor

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 20, 2019
@mrbobbytables
Copy link

This project is being archived, closing open issues and PRs.
Please see this PR for more information: kubernetes/community#6632

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api broker-api-spec-compliance lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

10 participants