-
Notifications
You must be signed in to change notification settings - Fork 385
How should we treat OSB tags? #497
Comments
FYI @dtaylor113 @jeff-phillips-18 tags are how we would categorize and filter things |
Moving to 0.0.3 because we will not get to it before then. |
Moving this into 0.1.0 since we will need to decide on OSB tags before we provide backward-compatibility guarantees by then |
Since labels and annotations are name/value pairs, but tags are just strings it doesn't seem like there's a good spot put them on the kueb core resource model. This would seem to then imply that we're probably going to have to keep this info in our own property - like we have now. Its just too bad that we can't easily search over it with some native kube search facility. We should have a brief chat about this but I'd suggest we close this issue. |
We could also remove both 'tags' and 'requires' and figure out how to treat
them later.
…On Fri, May 12, 2017 at 9:08 PM, Doug Davis ***@***.***> wrote:
Since labels and annotations are name/value pairs, but tags are just
strings it doesn't seem like there's a good spot put them on the kueb core
resource model. This would seem to then imply that we're probably going to
have to keep this info in our own property - like we have now. Its just too
bad that we can't easily search over it with some native kube search
facility. We should have a brief chat about this but I'd suggest we close
this issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#497 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWXmJvxGB_ny72LGCIF_LHjTzPhosIjks5r5QKbgaJpZM4MXNFR>
.
|
true, that would be the super safe option for beta. Haven't thought much about 'requires' yet - does anyone think it would ever be more than just an array of strings to us? I know at some point we'll need to look at it and perhaps do something (like reject a serviceClass if we don't support one of the "requires") but would we ever store it as something else? |
Please do not remove tags completely, if you want to change it to an alpha field until you decide what to do long term that's fine. |
I will open a PR to change the name of |
We're moving all |
to be clear, its just one property "OSBTags" we're moving, not all OSB properties |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
This project is being archived, closing open issues and PRs. |
The OSB API provides tags, a list of strings, to do the type of filtering that kubernetes uses labels for. This issue is to determine if we should:
cc @jwforres
The text was updated successfully, but these errors were encountered: