Skip to content
This repository has been archived by the owner on Jul 28, 2019. It is now read-only.

Fix custom-docker-opts #271

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Fix custom-docker-opts #271

merged 1 commit into from
Dec 20, 2018

Conversation

jc-sanchez
Copy link
Contributor

docker.service fails to start because /dind/containerd does not exist.
Move the creation of the directory from wrapkubeadm to the Dockerfile
Fixes #266

docker.service fails to start because /dind/containerd does not exist.
Move the creation of the directory from wrapkubeadm to the Dockerfile
Fixes #266
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 8, 2018
@mattmb mattmb mentioned this pull request Dec 10, 2018
@jc-sanchez
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 13, 2018
@jc-sanchez
Copy link
Contributor Author

/assign @roberthbailey

@jc-sanchez
Copy link
Contributor Author

/cc @ivan4th

@k8s-ci-robot k8s-ci-robot requested a review from ivan4th December 13, 2018 13:27
@roberthbailey
Copy link

Re-assigning to project maintainers.

/assign @pigmej @ivan4th
/unassign @roberthbailey

@k8s-ci-robot k8s-ci-robot assigned ivan4th and pigmej and unassigned roberthbailey Dec 13, 2018
@ivan4th
Copy link
Contributor

ivan4th commented Dec 20, 2018

Thanks for the PR!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan4th, jc-sanchez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3fc17d5 into kubernetes-retired:master Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insecure registries not working with latest fixed 1.10
5 participants