Skip to content
This repository has been archived by the owner on Jul 28, 2019. It is now read-only.

Fix k8s master (1.14) #251

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Nov 14, 2018

Always use CoreDNS and remove the feature gate from config.
Add workaround for unifiedControlPlaneImage removal kubernetes/kubernetes#70793
Fixes #250

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2018
@ivan4th ivan4th changed the title Fix k8s master (1.14) [WiP] Fix k8s master (1.14) Nov 14, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2018
@ivan4th ivan4th force-pushed the fix-k8s-master-1-14 branch from bebfb81 to d19d04d Compare November 14, 2018 11:25
Always use CoreDNS and remove the feature gate from config.
Add workaround for `unifiedControlPlaneImage` removal kubernetes/kubernetes#70793
Fixes kubernetes-retired#250
@ivan4th ivan4th force-pushed the fix-k8s-master-1-14 branch from d19d04d to a8234bd Compare November 14, 2018 17:57
@ivan4th ivan4th changed the title [WiP] Fix k8s master (1.14) Fix k8s master (1.14) Nov 14, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2018
Copy link
Contributor

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2018
@lukaszo
Copy link
Contributor

lukaszo commented Nov 14, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan4th, lukaszo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5debf38 into kubernetes-retired:master Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubeadm init fails when building from source
4 participants