Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.14.x] CoreDNS Local Templating issue. #1900

Conversation

dominicgunn
Copy link
Contributor

Changes

  • Fixes a templating issue when CoreDNS Local is enabled.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2020
@dominicgunn
Copy link
Contributor Author

dominicgunn commented Aug 13, 2020

/lgtm

@dominicgunn dominicgunn added this to the v0.14.7 milestone Aug 13, 2020
@dominicgunn dominicgunn merged commit 3240cf3 into kubernetes-retired:v0.14.x Aug 13, 2020
@dominicgunn dominicgunn deleted the v0.14.x-fix-templating-issue branch August 13, 2020 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants