Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Conversation

davidmccormick
Copy link
Contributor

Allow cloud-controller-manager and CSI in master branch for further testing.
Both are disabled by default. We need to test these in readiness for when EBS volume provisioning will be removed from the kube-controller-manager in-tree drivers.
By adding CSI we can provision EBS volumes without the in-tree drivers.
Both cloud-controller-manager and CSI are working in new clusters but the migration code is problematic and can get stuck detaching a volume from a removed non-csi node...

E0217 22:32:13.112266       1 reconciler.go:238] attacherDetacher.DetachVolume failed to start for volume "pvc-5b937379-4cf4-4cb9-877d-c978ca30626f" (UniqueName: "kubernetes.io/aws-ebs/aws://eu-west-2a/vol-05515c17b1d470bdd") on node "ip-172-31-30-191.eu-west-2.compute.internal" : DetachVolume.NodeUsingCSIPlugin failed for volume "pvc-5b937379-4cf4-4cb9-877d-c978ca30626f" (UniqueName: "kubernetes.io/aws-ebs/aws://eu-west-2a/vol-05515c17b1d470bdd") on node "ip-172-31-30-191.eu-west-2.compute.internal" : csinode.storage.k8s.io "ip-172-31-30-191.eu-west-2.compute.internal" not found
E0217 22:32:13.212540       1 reconciler.go:238] attacherDetacher.DetachVolume failed to start for volume "pvc-5b937379-4cf4-4cb9-877d-c978ca30626f" (UniqueName: "kubernetes.io/aws-ebs/aws://eu-west-2a/vol-05515c17b1d470bdd") on node "ip-172-31-30-191.eu-west-2.compute.internal" : DetachVolume.NodeUsingCSIPlugin failed for volume "pvc-5b937379-4cf4-4cb9-877d-c978ca30626f" (UniqueName: "kubernetes.io/aws-ebs/aws://eu-west-2a/vol-05515c17b1d470bdd") on node "ip-172-31-30-191.eu-west-2.compute.internal" : csinode.storage.k8s.io "ip-172-31-30-191.eu-west-2.compute.internal" not found
E0217 22:32:13.312775       1 reconciler.go:238] attacherDetacher.DetachVolume failed to start for volume "pvc-5b937379-4cf4-4cb9-877d-c978ca30626f" (UniqueName: "kubernetes.io/aws-ebs/aws://eu-west-2a/vol-05515c17b1d470bdd") on node "ip-172-31-30-191.eu-west-2.compute.internal" : DetachVolume.NodeUsingCSIPlugin failed for volume "pvc-5b937379-4cf4-4cb9-877d-c978ca30626f" (UniqueName: "kubernetes.io/aws-ebs/aws://eu-west-2a/vol-05515c17b1d470bdd") on node "ip-172-31-30-191.eu-west-2.compute.internal" : csinode.storage.k8s.io "ip-172-31-30-191.eu-west-2.compute.internal" not found

…efault.

Add Kubernetes CSI interface and AWS Ebs drivers as an experimental feature - also disabled by default.

Migrate existing in-tree pv's to CSI provisioned.

Make warnings more prominent.  Turn up logging to CSI components for testing.

remove etcdadm usage of read -u

Port fix from v0.15.x branch

Bump versions

Make debug logging a toggle within feature
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidmccormick
You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 17, 2020
@davidmccormick davidmccormick added this to the v0.16.0 milestone Feb 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #1835 into master will decrease coverage by 0.17%.
The diff coverage is 4.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
- Coverage   24.58%   24.41%   -0.18%     
==========================================
  Files          98       98              
  Lines        5072     5116      +44     
==========================================
+ Hits         1247     1249       +2     
- Misses       3685     3727      +42     
  Partials      140      140
Impacted Files Coverage Δ
pkg/api/types.go 0% <ø> (ø) ⬆️
pkg/api/cluster.go 0% <0%> (ø) ⬆️
pkg/model/node_pool_config.go 22.89% <0%> (-1.79%) ⬇️
pkg/model/node_pool_compile.go 60.25% <100%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34d9b6...53a4b67. Read the comment docs.

@davidmccormick davidmccormick merged commit c59afae into kubernetes-retired:master Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants