Add Riemann event sink and bug fixes

[mcorbin]

This PR supersedes 1339. Thanks @shmish111, your code helped me a lot.

• Update riemann-go-client version
• Add Riemann event sink
• Moves code in common/riemann/riemann.go
• Fix a bug on Riemann metrics sink for labeled metrics

cc @jamtur01 and @jsoriano for review

[k8s-reviewable]

This change is 

[k8s-ci-robot]

Hi @mcorbin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jsoriano]

Reviewed 17 of 17 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

common/riemann/riemann.go, line 17 at r1 (raw file):

package riemann

import (

Please, organize imports in groups according to goimports (https://github.com/golang/go/wiki/CodeReviewComments#imports), and do the same in all edited files.

---

events/sinks/riemann/driver_test.go, line 134 at r1 (raw file):

		Timestamp: timestamp,
		Events: []*kube_api.Event{
			&event1,

Set these events here inline directly?

---

metrics/sinks/riemann/driver.go, line 27 at r1 (raw file):

// contains the riemann client, the riemann configuration, and a RWMutex
type RiemannSink struct {

Can we reuse the definition in common?

---

vendor/github.com/riemann/riemann-go-client/.gitignore, line 3 at r1 (raw file):

riemann.log
riemann-*
vendor

I don't think we want to ignore vendor directory.

---

Comments from Reviewable

[mcorbin]

Review status: 12 of 17 files reviewed at latest revision, 4 unresolved discussions.

---

common/riemann/riemann.go, line 17 at r1 (raw file):

Previously, jsoriano (Jaime Soriano Pastor) wrote…

Please, organize imports in groups according to goimports (https://github.com/golang/go/wiki/CodeReviewComments#imports), and do the same in all edited files.

Hi, i used goimports on all files. Thanks ;)

---

events/sinks/riemann/driver_test.go, line 134 at r1 (raw file):

Previously, jsoriano (Jaime Soriano Pastor) wrote…

Set these events here inline directly?

Done, thanks

---

metrics/sinks/riemann/driver.go, line 27 at r1 (raw file):

Previously, jsoriano (Jaime Soriano Pastor) wrote…

Can we reuse the definition in common?

I tried and failed. All sinks (influx, elasticsearch...) duplicates the sink struct in both events and metrics.

---

vendor/github.com/riemann/riemann-go-client/.gitignore, line 3 at r1 (raw file):

Previously, jsoriano (Jaime Soriano Pastor) wrote…

I don't think we want to ignore vendor directory.

I'm pretty new to Go, some projects consider pushing the vendor directory a bad practice, some projects dont. I don't really know what to do with the Riemann Go client.

---

Comments from Reviewable

[jsoriano]

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

vendor/github.com/riemann/riemann-go-client/.gitignore, line 3 at r1 (raw file):

Previously, mcorbin (Mathieu Corbin) wrote…

I'm pretty new to Go, some projects consider pushing the vendor directory a bad practice, some projects dont. I don't really know what to do with the Riemann Go client.

In heapster this directory is commited into the repository.

---

Comments from Reviewable

[mcorbin]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

vendor/github.com/riemann/riemann-go-client/.gitignore, line 3 at r1 (raw file):

Previously, jsoriano (Jaime Soriano Pastor) wrote…

In heapster this directory is commited into the repository.

Yes, but here it's riemann-go-client vendor directory, so it should not impact Heapster (i can not find a Heapster dependency in vendor with it's own vendor directory). Furthermore, riemann-go-client depends only on protobuf.

---

Comments from Reviewable

[jsoriano]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

vendor/github.com/riemann/riemann-go-client/.gitignore, line 3 at r1 (raw file):

Previously, mcorbin (Mathieu Corbin) wrote…

Yes, but here it's riemann-go-client vendor directory, so it should not impact Heapster (i can not find a Heapster dependency in vendor with it's own vendor directory). Furthermore, riemann-go-client depends only on protobuf.

Oh, you're right, my apologies, I was thinking it was the .gitignore of heapster repository.

---

Comments from Reviewable

[jsoriano]

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[DirectXMan12]

LGTM at a glance.

[DirectXMan12]

would like to see a review from @jamtur01 before merge, but if we don't get one soon, just ping me and I'll merge this.

[jamtur01]

@DirectXMan12 Apologies - didn't realize I was the blocker. This LGTM.

[DirectXMan12]

Awesome. Merging!