This repository has been archived by the owner on May 6, 2022. It is now read-only.
use defaults from DefaultTransport for our custom transport (ie timeouts) #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jboyd01
force-pushed
the
use-defaulttransport-defaults
branch
from
91aa47c to
4e8d1a3
Compare
|
Best repro test ever! 💯 |
carolynvs
approved these changes
Sep 27, 2018
shawn-hurley
approved these changes
Sep 27, 2018
|
Thanks to @carolynvs & @shawn-hurley for the review, I'll merge it. |
jboyd01
pushed a commit
to jboyd01/go-open-service-broker-client
that referenced
this pull request
Oct 15, 2018
jboyd01
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #132
to test using k8s service catalog, do a
svcat sync broker ups-brokerrepeatedly. Without the fix, you see the number of established connections grow as reported bysudo nsenter -t $BROKERPID --net netstat -n -pWith this fix, the number of established connections remains constant which is a small number related to the number of connections used within the last 90 seconds (IdleConnTimeout).