HTTP server for liveness probe, check registration socket exists #99

chrishenzie · 2020-08-10T14:23:40Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a liveness probe server that monitors the existence of the registration socket. Included are refactors to reduce code duplication checking for socket exists. Note that there are behavioral differences in how linux and windows systems check for sockets, see the bug in comments below.

Which issue(s) this PR fixes:

Fixes #57

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Adds a new flag --health-port. This is the port of the health check server for the node-driver-registrar, which checks if the registration socket exists. A value <= 0 disables the server. Server is disabled by default.

k8s-ci-robot · 2020-08-10T14:23:43Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-08-10T14:23:48Z

Welcome @chrishenzie!

It looks like this is your first PR to kubernetes-csi/node-driver-registrar 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/node-driver-registrar has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-08-10T14:23:48Z

Hi @chrishenzie. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chrishenzie · 2020-08-10T14:39:23Z

Replying to test CLA.

msau42 · 2020-08-10T16:59:09Z

/ok-to-test

msau42

Can you also update the README with the new argument, along with the deploy spec example to show how to use it?

msau42 · 2020-08-10T22:21:41Z

pkg/util/util_windows.go

+		return err
+	}
+	if socketExists {
+		// TODO: Until the bug - https://github.com/golang/go/issues/33357 is fixed, os.stat wouldn't return the


I think this comment fits better under DoesSocketExist to describe why we're not checking the file mode.

jsafrane · 2020-08-11T13:14:13Z

cmd/csi-node-driver-registrar/main.go

@@ -47,6 +47,7 @@ var (
 	connectionTimeout       = flag.Duration("connection-timeout", 0, "The --connection-timeout flag is deprecated")
 	csiAddress              = flag.String("csi-address", "/run/csi/socket", "Path of the CSI driver socket that the node-driver-registrar will connect to.")
 	kubeletRegistrationPath = flag.String("kubelet-registration-path", "", "Path of the CSI driver socket on the Kubernetes host machine.")
+	livenessProbePort       = flag.Int("liveness-probe-port", 9090, "HTTP port for liveness probe server.")


CSI drivers on nodes often run with hostNetwork: true, which means that the liveness probe port must be open on the node. It becomes increasingly more complicated to make sure the port does not clash with any other port that the node needs.

It should be at least possible to turn the probe off (--liveness-probe-port=0?)

Maybe don't default the port, and if unset, then don't enable this?

That could work. Still, I wish there was an exec probe instead (maybe sometime in future, not this PR)

Can you clarify what you mean by exec probe?

I believe they mean doing something like this:

livenessProbe: exec: command: - stat - /registration/io.kubernetes.storage.mock-reg.sock

May make a good argument for us to have a distroless + very minimal utilities base image for things like this.

jsafrane · 2020-08-11T13:32:33Z

Now that I think about this, can the registrar just have inotify on the socket? If another driver registrar starts on the same node (e.g. someone deploys a second DaemonSet for the same driver), the first one should detect that its sockets are deleted and exit. With liveness probe, it is likely to miss the time when the socket is deleted and the old registrar will continue running even if there is another registrar serving the socket.

chrishenzie · 2020-08-11T15:41:25Z

@jsafrane Just clarifying the approach, you would prefer the liveness probe is removed and instead os.Exit() when the registration socket is deleted by util.CleanupSocketFile() (if a second instance is brought up) ? It looks like this fsnotify library may help, am I free to add this dependency or are there other approaches to consider?

msau42 · 2020-08-11T18:21:57Z

Now that I think about this, can the registrar just have inotify on the socket? If another driver registrar starts on the same node (e.g. someone deploys a second DaemonSet for the same driver), the first one should detect that its sockets are deleted and exit. With liveness probe, it is likely to miss the time when the socket is deleted and the old registrar will continue running even if there is another registrar serving the socket.

What prevents the restarted driver-registrar from coming up again, recreating the socket, and then ping-pong back and forth forever?

jsafrane · 2020-08-12T08:15:10Z

What prevents the restarted driver-registrar from coming up again, recreating the socket, and then ping-pong back and forth forever?

Nothing. But letting two registrar pods listen on the same socket is IMO even worse.

msau42 · 2020-08-12T17:29:03Z

letting two registrar pods listen on the same socket

I don't think this is what's happening. The 2nd registrar will come up, delete the registration socket, and listen on the new one. The 1st driver-registrar doesn't get any requests. I believe @chrishenzie verified this by checking the logs of both.

I was surprised that the 1st registrar didn't error out when the socket file it was listening on got removed.

msau42 · 2020-08-12T17:31:04Z

The purpose of this PR is to make it so that: 1) if 2 of the same driver is running on the same node, node operations are still functional. and 2) when one of the duplicate driver instances is removed and the socket gets deleted, it doesn't cause the driver to be unregistered forever.

jsafrane · 2020-08-12T18:25:18Z

The 2nd registrar will come up, delete the registration socket, and listen on the new one. The 1st driver-registrar doesn't get any requests

If that's the case, then I withdraw my objections. It's quite surprising though.

Still, please make the port optional.

msau42 · 2020-08-13T01:28:28Z

README.md

@@ -50,6 +50,11 @@ There are two UNIX domain sockets used by the node-driver-registrar:
  `/var/lib/kubelet/plugins/<drivername.example.com>/csi.sock). Note this is NOT
  the path to the registration socket.

+### Optional arguments
+
+* `--health-port`: This is the port of the health check server for the node-driver-registrar.


Can you briefly describe what the health check is doing here?

msau42 · 2020-08-13T01:29:25Z

README.md

+### Optional arguments
+
+* `--health-port`: This is the port of the health check server for the node-driver-registrar.
+  A value of 0 will disable the server.


Also mention by default it's disabled

msau42 · 2020-08-13T01:30:51Z

cmd/csi-node-driver-registrar/node_register.go

@@ -78,6 +81,33 @@ func buildSocketPath(csiDriverName string) string {
 	return fmt.Sprintf("/registration/%s-reg.sock", csiDriverName)
 }

+func healthzServer(socketPath string, port int) {
+	if port == 0 {


check for negative values too

msau42 · 2020-08-13T01:35:20Z

cmd/csi-node-driver-registrar/node_register.go

+			w.Write([]byte(err.Error()))
+			klog.Errorf("health check failed: %+v", err)
+		} else if !socketExists {
+			w.WriteHeader(http.StatusInternalServerError)


Do we want to distinguish error codes and have this one be StatusNotFound?

msau42 · 2020-08-13T01:39:59Z

pkg/util/util_linux.go

+
+func DoesSocketExist(socketPath string) (bool, error) {
+	fi, err := os.Stat(socketPath)
+	if err == nil && (fi.Mode()&os.ModeSocket) != 0 {


This isn't your change (and maybe we can think about this in a followup), but I wonder if it's worth it to log a warning or return an error if the file is not a socket instead of returning false. I wouldn't expect creating a listening socket would work if the file already existed and it's not a socket file.

Yeah good point, if we dropped something else there with the same name the registrar wouldn't be able to create a socket.

README.md

msau42 · 2020-08-13T01:47:30Z

Can you also add a release note in the PR description that mentions the new flag added and what it does?

README.md

msau42 · 2020-08-13T02:21:45Z

README.md

@@ -76,11 +81,19 @@ the actual driver's name.
          args:


@jsafrane you missed updating the image registry here :-P

I can tackle this in a separate PR.

chrishenzie · 2020-08-17T16:28:18Z

/retest

msau42 · 2020-08-17T23:08:35Z

/lgtm
/approve

Thanks for adding this!

k8s-ci-robot · 2020-08-17T23:08:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrishenzie, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

a0f195cc Merge pull request kubernetes-csi#106 from msau42/fix-canary 7100c120 Only set staging registry when running canary job b3c65f9c Merge pull request kubernetes-csi#99 from msau42/add-release-process e53f3e85 Merge pull request kubernetes-csi#103 from msau42/fix-canary d1294628 Document new method for adding CI jobs are new K8s versions e73c2ce5 Use staging registry for canary tests 2c098465 Add cleanup instructions to release-notes generation 60e1cd3 Merge pull request kubernetes-csi#98 from pohly/kubernetes-1-19-fixes 0979c09 prow.sh: fix E2E suite for Kubernetes >= 1.18 3b4a2f1 prow.sh: fix installing Go for Kubernetes 1.19.0 1fbb636 Merge pull request kubernetes-csi#97 from pohly/go-1.15 82d108a switch to Go 1.15 d8a2530 Merge pull request kubernetes-csi#95 from msau42/add-release-process 843bddc Add steps on promoting release images 0345a83 Merge pull request kubernetes-csi#94 from linux-on-ibm-z/bump-timeout 1fdf2d5 cloud build: bump timeout in Prow job 41ec6d1 Merge pull request kubernetes-csi#93 from animeshk08/patch-1 5a54e67 filter-junit: Fix gofmt error 0676fcb Merge pull request kubernetes-csi#92 from animeshk08/patch-1 36ea4ff filter-junit: Fix golint error f5a4203 Merge pull request kubernetes-csi#91 from cyb70289/arm64 43e50d6 prow.sh: enable building arm64 image 0d5bd84 Merge pull request kubernetes-csi#90 from pohly/k8s-staging-sig-storage 3df86b7 cloud build: k8s-staging-sig-storage c5fd961 Merge pull request kubernetes-csi#89 from pohly/cloud-build-binfmt db0c2a7 cloud build: initialize support for running commands in Dockerfile be902f4 Merge pull request kubernetes-csi#88 from pohly/multiarch-windows-fix 340e082 build.make: optional inclusion of Windows in multiarch images 5231f05 build.make: properly declare push-multiarch 4569f27 build.make: fix push-multiarch ambiguity 17dde9e Merge pull request kubernetes-csi#87 from pohly/cloud-build bd41690 cloud build: initial set of shared files 9084fec Merge pull request kubernetes-csi#81 from msau42/add-release-process 6f2322e Update patch release notes generation command 0fcc3b1 Merge pull request kubernetes-csi#78 from ggriffiths/fix_csi_snapshotter_rbac_version_set d8c76fe Support local snapshot RBAC for pull jobs c1bdf5b Merge pull request kubernetes-csi#80 from msau42/add-release-process ea1f94a update release tools instructions 152396e Merge pull request kubernetes-csi#77 from ggriffiths/snapshotter201_update 7edc146 Update snapshotter to version 2.0.1 4cf843f Merge pull request kubernetes-csi#76 from pohly/build-targets 3863a0f build for multiple platforms only in CI, add s390x 8322a7d Merge pull request kubernetes-csi#72 from pohly/hostpath-update 7c5a89c prow.sh: use 1.3.0 hostpath driver for testing b8587b2 Merge pull request kubernetes-csi#71 from wozniakjan/test-vet fdb3218 Change 'make test-vet' to call 'go vet' d717c8c Merge pull request kubernetes-csi#69 from pohly/test-driver-config a1432bc Merge pull request kubernetes-csi#70 from pohly/kubelet-feature-gates 5f74333 prow.sh: also configure feature gates for kubelet 84f78b1 prow.sh: generic driver installation 3c34b4f Merge pull request kubernetes-csi#67 from windayski/fix-link fa90abd fix incorrect link ff3cc3f Merge pull request kubernetes-csi#54 from msau42/add-release-process ac8a021 Document the process for releasing a new sidecar 23be652 Merge pull request kubernetes-csi#65 from msau42/update-hostpath 6582f2f Update hostpath driver version to get fix for connection-timeout 4cc9174 Merge pull request kubernetes-csi#64 from ggriffiths/snapshotter_2_version_update 8191eab Update snapshotter to version v2.0.0 3c463fb Merge pull request kubernetes-csi#61 from msau42/enable-snapshots 8b0316c Fix overriding of junit results by using unique names for each e2e run 5f444b8 Merge pull request kubernetes-csi#60 from saad-ali/updateHostpathVersion af9549b Update prow hostpath driver version to 1.3.0-rc2 f6c74b3 Merge pull request kubernetes-csi#57 from ggriffiths/version_gt_kubernetes_fix fc80975 Fix version_gt to work with kubernetes prefix 9f1f3dd Merge pull request kubernetes-csi#56 from msau42/enable-snapshots b98b2ae Enable snapshot tests in 1.17 to be run in non-alpha jobs. 9ace020 Merge pull request kubernetes-csi#52 from msau42/update-readme 540599b Merge pull request kubernetes-csi#53 from msau42/fix-make a4e6299 fix syntax for ppc64le build 771ca6f Merge pull request kubernetes-csi#49 from ggriffiths/prowsh_improve_version_gt d7c69d2 Merge pull request kubernetes-csi#51 from msau42/enable-multinode 4ad6949 Improve snapshot pod running checks and improve version_gt 53888ae Improve README by adding an explicit Kubernetes dependency section 9a7a685 Create a kind cluster with two worker nodes so that the topology feature can be tested. Test cases that test accessing volumes from multiple nodes need to be skipped 4ff2f5f Merge pull request kubernetes-csi#50 from darkowlzz/kind-0.6.0 80bba1f Use kind v0.6.0 6d674a7 Merge pull request kubernetes-csi#47 from Pensu/multi-arch 8adde49 Merge pull request kubernetes-csi#45 from ggriffiths/snapshot_beta_crds 003c14b Add snapshotter CRDs after cluster setup a41f386 Merge pull request kubernetes-csi#46 from mucahitkurt/kind-cluster-cleanup 1eaaaa1 Delete kind cluster after tests run. 83a4ef1 Adding build for ppc64le 4fcafec Merge pull request kubernetes-csi#43 from pohly/system-pod-logging f41c135 prow.sh: also log output of system containers ee22a9c Merge pull request kubernetes-csi#42 from pohly/use-vendor-dir 8067845 travis.yml: also use vendor directory 23df4ae prow.sh: use vendor directory if available a53bd4c Merge pull request kubernetes-csi#41 from pohly/go-version c8a1c4a better handling of Go version 5e773d2 update CI to use Go 1.13.3 f419d74 Merge pull request kubernetes-csi#40 from msau42/add-1.16 e0fde8c Add new variables for 1.16 and remove 1.13 adf00fe Merge pull request kubernetes-csi#36 from msau42/full-clone f1697d2 Do full git clones in travis. Shallow clones are causing test-subtree errors when the depth is exactly 50. 2c81919 Merge pull request kubernetes-csi#34 from pohly/go-mod-tidy 518d6af Merge pull request kubernetes-csi#35 from ddebroy/winbld2 2d6b3ce Build Windows only for amd64 c1078a6 go-get-kubernetes.sh: automate Kubernetes dependency handling 194289a update Go mod support 0affdf9 Merge pull request kubernetes-csi#33 from gnufied/enable-hostpath-expansion 6208f6a Enable hostpath expansion 6ecaa76 Merge pull request kubernetes-csi#30 from msau42/fix-windows ea2f1b5 build windows binaries with .exe suffix 2d33550 Merge pull request kubernetes-csi#29 from mucahitkurt/create-2-node-kind-cluster a8ea8bc create 2-node kind cluster since topology support is added to hostpath driver df8530d Merge pull request kubernetes-csi#27 from pohly/dep-vendor-check 35ceaed prow.sh: install dep if needed f85ab5a Merge pull request kubernetes-csi#26 from ddebroy/windows1 9fba09b Add rule for building Windows binaries 0400867 Merge pull request kubernetes-csi#25 from msau42/fix-master-jobs dc0a5d8 Update kind to v0.5.0 aa85b82 Merge pull request kubernetes-csi#23 from msau42/fix-master-jobs f46191d Kubernetes master changed the way that releases are tagged, which needed changes to kind. There are 3 changes made to prow.sh: 1cac3af Merge pull request kubernetes-csi#22 from msau42/add-1.15-jobs 0c0dc30 prow.sh: tag master images with a large version number f4f73ce Merge pull request kubernetes-csi#21 from msau42/add-1.15-jobs 4e31f07 Change default hostpath driver name to hostpath.csi.k8s.io 4b6fa4a Update hostpath version for sidecar testing to v1.2.0-rc2 ecc7918 Update kind to v0.4.0. This requires overriding Kubernetes versions with specific patch versions that kind 0.4.0 supports. Also, feature gate setting is only supported on 1.15+ due to kind.sigs.k8s.io/v1alpha3 and kubeadm.k8s.io/v1beta2 dependencies. a6f21d4 Add variables for 1.15 db8abb6 Merge pull request kubernetes-csi#20 from pohly/test-driver-config b2f4e05 prow.sh: flexible test driver config 0399988 Merge pull request kubernetes-csi#19 from pohly/go-mod-vendor 066143d build.make: allow repos to use 'go mod' for vendoring 0bee749 Merge pull request kubernetes-csi#18 from pohly/go-version e157b6b update to Go 1.12.4 88dc9a4 Merge pull request kubernetes-csi#17 from pohly/prow 0fafc66 prow.sh: skip sanity testing if component doesn't support it bcac1c1 Merge pull request kubernetes-csi#16 from pohly/prow 0b10f6a prow.sh: update csi-driver-host-path 0c2677e Merge pull request kubernetes-csi#15 from pengzhisun/master ff9bce4 Replace 'return' to 'exit' to fix shellcheck error c60f382 Merge pull request kubernetes-csi#14 from pohly/prow 7aaac22 prow.sh: remove AllAlpha=all, part II 6617773 Merge pull request kubernetes-csi#13 from pohly/prow cda2fc5 prow.sh: avoid AllAlpha=true 546d550 prow.sh: debug failing KinD cluster creation 9b0d9cd build.make: skip shellcheck if Docker is not available aa45a1c prow.sh: more efficient execution of individual tests f3d1d2d prow.sh: fix hostpath driver version check 31dfaf3 prow.sh: fix running of just "alpha" tests f501443 prow.sh: AllAlpha=true for unknown Kubernetes versions 95ae9de Merge pull request kubernetes-csi#9 from pohly/prow d87eccb prow.sh: switch back to upstream csi-driver-host-path 6602d38 prow.sh: different E2E suite depending on Kubernetes version 741319b prow.sh: improve building Kubernetes from source 29545bb prow.sh: take Go version from Kubernetes source 429581c prow.sh: pull Go version from travis.yml 0a0fd49 prow.sh: comment clarification 2069a0a Merge pull request kubernetes-csi#11 from pohly/verify-shellcheck 55212ff initial Prow test job 6c7ba1b build.make: integrate shellcheck into "make test" b2d25d4 verify-shellcheck.sh: make it usable in csi-release-tools 3b6af7b Merge pull request kubernetes-csi#12 from pohly/local-e2e-suite 104a1ac build.make: avoid unit-testing E2E test suite 34010e7 Merge pull request kubernetes-csi#10 from pohly/vendor-check e6db50d check vendor directory fb13c51 verify-shellcheck.sh: import from Kubernetes 94fc1e3 build.make: avoid unit-testing E2E test suite 849db0a Merge pull request kubernetes-csi#8 from pohly/subtree-check-relax cc564f9 verify-subtree.sh: relax check and ignore old content 33d58fd Merge pull request kubernetes-csi#5 from pohly/test-enhancements be8a440 Merge pull request kubernetes-csi#4 from pohly/canary-fix b0336b5 build.make: more readable "make test" output 09436b9 build.make: fix pushing of "canary" image from master branch 147892c build.make: support suppressing checks 154e33d build.make: clarify usage of "make V=1" git-subtree-dir: release-tools git-subtree-split: a0f195cc2ddc2a1f07d4d3e46fc08187db358f94

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 10, 2020

k8s-ci-robot requested review from jsafrane and lpabon August 10, 2020 14:23

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 10, 2020

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2020

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 10, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2020

msau42 reviewed Aug 10, 2020

View reviewed changes

jsafrane reviewed Aug 11, 2020

View reviewed changes

chrishenzie force-pushed the http-liveness-probe branch 2 times, most recently from e01d7e1 to 93f1bb3 Compare August 12, 2020 01:00

msau42 reviewed Aug 13, 2020

View reviewed changes

HTTP server for liveness probe, check registration socket exists

d530705

chrishenzie force-pushed the http-liveness-probe branch from 93f1bb3 to d530705 Compare August 14, 2020 20:08

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 14, 2020

k8s-ci-robot assigned msau42 Aug 17, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2020

k8s-ci-robot merged commit 6d15148 into kubernetes-csi:master Aug 17, 2020

chrishenzie deleted the http-liveness-probe branch August 19, 2020 21:43

pohly mentioned this pull request Oct 12, 2020

master: update release-tools #115

Merged

chrishenzie mentioned this pull request Nov 3, 2020

REQUEST: New membership for chrishenzie kubernetes/org#2309

Closed

6 tasks

chrishenzie mentioned this pull request Nov 11, 2020

REQUEST: New membership for chrishenzie kubernetes/org#2328

Closed

6 tasks

msau42 mentioned this pull request Jul 13, 2021

Provide different running modes for node-driver-registrar, add a run mode to detect if the kubelet plugin registration failed #152

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTTP server for liveness probe, check registration socket exists #99

HTTP server for liveness probe, check registration socket exists #99

chrishenzie commented Aug 10, 2020 •

edited

Loading

k8s-ci-robot commented Aug 10, 2020

k8s-ci-robot commented Aug 10, 2020

k8s-ci-robot commented Aug 10, 2020

chrishenzie commented Aug 10, 2020

msau42 commented Aug 10, 2020

msau42 left a comment

msau42 Aug 10, 2020

jsafrane Aug 11, 2020

msau42 Aug 11, 2020

jsafrane Aug 12, 2020 •

edited

Loading

msau42 Aug 12, 2020

chrishenzie Aug 14, 2020 •

edited

Loading

jsafrane commented Aug 11, 2020

chrishenzie commented Aug 11, 2020 •

edited

Loading

msau42 commented Aug 11, 2020

jsafrane commented Aug 12, 2020

msau42 commented Aug 12, 2020

msau42 commented Aug 12, 2020

jsafrane commented Aug 12, 2020

msau42 Aug 13, 2020

msau42 Aug 13, 2020

msau42 Aug 13, 2020

msau42 Aug 13, 2020

msau42 Aug 13, 2020

chrishenzie Aug 14, 2020

msau42 commented Aug 13, 2020

msau42 Aug 13, 2020

chrishenzie Aug 14, 2020

chrishenzie commented Aug 17, 2020

msau42 commented Aug 17, 2020

k8s-ci-robot commented Aug 17, 2020

HTTP server for liveness probe, check registration socket exists #99

HTTP server for liveness probe, check registration socket exists #99

Conversation

chrishenzie commented Aug 10, 2020 • edited Loading

k8s-ci-robot commented Aug 10, 2020

k8s-ci-robot commented Aug 10, 2020

k8s-ci-robot commented Aug 10, 2020

chrishenzie commented Aug 10, 2020

msau42 commented Aug 10, 2020

msau42 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsafrane Aug 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrishenzie Aug 14, 2020 • edited Loading

Choose a reason for hiding this comment

jsafrane commented Aug 11, 2020

chrishenzie commented Aug 11, 2020 • edited Loading

msau42 commented Aug 11, 2020

jsafrane commented Aug 12, 2020

msau42 commented Aug 12, 2020

msau42 commented Aug 12, 2020

jsafrane commented Aug 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msau42 commented Aug 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrishenzie commented Aug 17, 2020

msau42 commented Aug 17, 2020

k8s-ci-robot commented Aug 17, 2020

chrishenzie commented Aug 10, 2020 •

edited

Loading

jsafrane Aug 12, 2020 •

edited

Loading

chrishenzie Aug 14, 2020 •

edited

Loading

chrishenzie commented Aug 11, 2020 •

edited

Loading