Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pull registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.11.0 #415

Closed
ThatsMrTalbot opened this issue May 29, 2024 · 12 comments
Closed
Assignees

Comments

@ThatsMrTalbot
Copy link

When attempting to pull the image for the new v2.11.0 I get the following:

$ docker pull registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.11.0
Error response from daemon: manifest for registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.11.0 not found: manifest unknown: Failed to fetch "v2.11.0"
@humblec
Copy link
Contributor

humblec commented May 29, 2024

Looking into this.. Atm, I don't see this tag in the artificatory, thus the image promotion also has not happened.

@humblec
Copy link
Contributor

humblec commented May 29, 2024

/assign @humblec

@xing-yang
Copy link
Contributor

Microsoft has broken their base container images: microsoft/Windows-Containers#493
We can't build Windows images.

iPraveenParihar added a commit to iPraveenParihar/rook that referenced this issue Jun 19, 2024
Below csi sidecars are updated with latest available versions

csi-resizer: v1.11.1
csi-provisioner: v5.0.1
csi-attacher: v4.6.1
csi-snapshotter: v8.0.1
csi-node-driver-registrar: v2.10.1
(v2.11.0 is not yet available in registry due to
kubernetes-csi/node-driver-registrar#415)

Signed-off-by: Praveen M <m.praveen@ibm.com>
@ThatsMrTalbot
Copy link
Author

The underlying issue has still not been resolved so I understand that your build still will not be working.

Since its been a month now is it worth pinning to a previous base image? I have seen several other projects doing this - for example https://github.com/jenkinsci/docker-ssh-agent/pull/433/files

@jbg
Copy link

jbg commented Jul 7, 2024

This seems to affect all OSes, not just Windows? Why not publish images for Linux?

@luhi-DT
Copy link

luhi-DT commented Jul 10, 2024

I can see from microsoft/Windows-Containers#493 that they fixed the issue, does this now mean the images can be released? :)

@andyzhangx
Copy link
Member

@xing-yang do you know how to retrigger the image build for v2.11.0? or do we need another patch version(e.g. v2.11.1) to build image? liveness-probe:v2.13.0 has same image build issue.

https://console.cloud.google.com/gcr/images/k8s-staging-sig-storage/global/csi-node-driver-registrar

image

@jsafrane
Copy link
Contributor

jsafrane commented Jul 16, 2024

Please pull registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.11.1, which has just been released.
/close

@jsafrane
Copy link
Contributor

similarly, a fixed livenessprobe is now available as registry.k8s.io/sig-storage/livenessprobe:v2.13.1

@jsafrane
Copy link
Contributor

@ThatsMrTalbot @andyzhangx @luhi-DT Can you please confirm that the new Windows images are working now? I have no way to test this.

@ThatsMrTalbot
Copy link
Author

Sorry @jsafrane, I do not use the windows images. I just needed the linux ones to be pushed up.

@andyzhangx
Copy link
Member

andyzhangx commented Jul 17, 2024

@ThatsMrTalbot @andyzhangx @luhi-DT Can you please confirm that the new Windows images are working now? I have no way to test this.

@jsafrane yes, the new windows images work well, I have a image version upgrade PR which triggers the windows e2e tests, test pass: kubernetes-csi/csi-driver-smb#796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants