Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifests based on new CRD validation rules #1076

Merged
merged 2 commits into from
May 13, 2024

Conversation

xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented May 1, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Update manifests with controller-gen@v0.15.0 and validation rules added by #1073.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This PR depends on #1073.

Does this PR introduce a user-facing change?:

Update manifests with controller-gen@v0.15.0 and new validation rules. Minimum required Kubernetes version is 1.25 for these validation rules.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 1, 2024
@k8s-ci-robot k8s-ci-robot requested review from ggriffiths and pohly May 1, 2024 01:56
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2024
@xing-yang
Copy link
Collaborator Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 1, 2024
@xing-yang xing-yang changed the title Test crd validation Test CRD validation May 1, 2024
@xing-yang xing-yang force-pushed the test_crd_validation branch from 96e58e5 to e743f08 Compare May 7, 2024 00:42
@xing-yang xing-yang force-pushed the test_crd_validation branch from e743f08 to 895a10c Compare May 7, 2024 01:01
@xing-yang xing-yang changed the title Test CRD validation Update manifests based on new CRD validation rules May 7, 2024
@xing-yang
Copy link
Collaborator Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@leonardoce
Copy link
Contributor

I run my YAML test suite over this branch, and everything is right.
I manually created a volumesnapshot and deleted it, and did the same with a volumegroupsnapshot (using the hostpath.csi.k8s.io driver)
Everything looks good to me.

@leonardoce
Copy link
Contributor

The CRD definition is ok, too, compared with the one generated by the ./hack/update-crd.sh script.

@leonardoce
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@leonardoce: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deepakkinni
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakkinni, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0932517 into kubernetes-csi:master May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants