-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manifests based on new CRD validation rules #1076
Update manifests based on new CRD validation rules #1076
Conversation
/hold |
and new validation rules
96e58e5
to
e743f08
Compare
e743f08
to
895a10c
Compare
/hold cancel |
I run my YAML test suite over this branch, and everything is right. |
The CRD definition is ok, too, compared with the one generated by the |
/lgtm |
@leonardoce: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakkinni, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Update manifests with controller-gen@v0.15.0 and validation rules added by #1073.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR depends on #1073.
Does this PR introduce a user-facing change?: