Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.1] Update github.com/kubernetes-csi/csi-lib-utils #735

Conversation

ialidzhikov
Copy link
Contributor

/sig storage
/kind bug

Part of #732

Does this PR introduce a user-facing change?:

external-provisioner now exits without output about goroutines when it fails to connect to the CSI driver.

from v0.9.0 to v0.9.2-0.20220505060022-bbda27282c12

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 5, 2022
@ialidzhikov
Copy link
Contributor Author

/cc @pohly

@k8s-ci-robot k8s-ci-robot requested a review from pohly May 5, 2022 14:25
@pohly
Copy link
Contributor

pohly commented May 5, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2022
@pohly
Copy link
Contributor

pohly commented May 5, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ialidzhikov, pohly
To complete the pull request process, please assign lpabon after the PR has been reviewed.
You can assign the PR to them by writing /assign @lpabon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pohly
Copy link
Contributor

pohly commented May 5, 2022

/assign @xing-yang

For approval.

@ialidzhikov
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@ialidzhikov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-1-23 16a6fe1 link true /test pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-1-23

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pohly
Copy link
Contributor

pohly commented May 6, 2022

Looks like the release-2.1 branch was not prepared to work with Kubernetes 1.23. It's old and will soon be unsupported. Do you really need it to be updated?

@ialidzhikov
Copy link
Contributor Author

ialidzhikov commented May 6, 2022

We are still using external-provisioner@2.1.2. I would appreciate if it is possible to cut a new patch release from the release-2.1 branch that includes this PR. If it is not possible we have to consider update to external-provisioner@2.2.x.

@pohly
Copy link
Contributor

pohly commented May 6, 2022

Why can you not update to a newer release?

@ialidzhikov
Copy link
Contributor Author

Ok, I will then update to 2.2.x when a fix containing #734 is cut (2.2.3).

@ialidzhikov
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@ialidzhikov: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants