-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only watch Pods and Nodes when Node Watcher is enabled #75
Comments
It also would be useful to address the scalability issue when the Node Watcher functionality is enabled. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
/lifecycle frozen |
/assign |
In the external-health-monitor-controller, we always watch all PVCs, Pods, Nodes:
https://github.com/kubernetes-csi/external-health-monitor/blob/v0.3.0/cmd/csi-external-health-monitor-controller/main.go#L210
We need to watch them to support the Node Watcher functionality which is disabled by default. This has caused scalability problems.
https://github.com/kubernetes-csi/external-health-monitor/blob/v0.3.0/cmd/csi-external-health-monitor-controller/main.go#L66
We should change the code to only watch Pods and Nodes when the Node Watcher component is enabled.
kubernetes/kubernetes#102452 (comment)
The text was updated successfully, but these errors were encountered: