Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RBAC for CSINode #146

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Update RBAC for CSINode #146

merged 1 commit into from
Apr 26, 2019

Conversation

lpabon
Copy link
Member

@lpabon lpabon commented Apr 26, 2019 •
edited
Loading

What type of PR is this?
/kind bug

Fixes #143

What this PR does / why we need it:
RBAC Rules updated

Does this PR introduce a user-facing change?:

* New RBAC rules updated to access CSINode

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Apr 26, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2019
@lpabon
Update RBAC for CSINode
1425846 
Signed-off-by: Luis Pabón <luis@portworx.com>
@lpabon
Copy link
Member Author

lpabon commented Apr 26, 2019

Tested: https://paste.fedoraproject.org/paste/tYYoBfW3LHxfH7iWzF1kpA

I didn't see any logs for CSINode, but mounting a volume worked.

msau42
msau42 reviewed Apr 26, 2019
View reviewed changes
Copy link
Collaborator

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpabon, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bf1237f into kubernetes-csi:master Apr 26, 2019
k8s-ci-robot added a commit that referenced this pull request Apr 26, 2019
@k8s-ci-robot
Merge pull request #147 from msau42/cherry-pick-rbac
6186e29 
Cherry-pick #146 to release-1.1: Update RBAC for CSINode
@AtkinsChang AtkinsChang mentioned this pull request Aug 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix rbac rules for csinode
3 participants
@lpabon @k8s-ci-robot @msau42