Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit nil error initialization. #114

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jan 6, 2019

initialization of nil make go-lint unhappy. Removing it via this PR.

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2019
@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2019

/assign @jsafrane
/assign @sbezverk

@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2019

/assign @jsafrane
/assign @sbezverk

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2019

@jsafrane initialization of nil make go-lint unhappy. Removing it via this PR.

@pohly
Copy link
Contributor

pohly commented Jan 6, 2019

Instead of explaining in a PR comment why this change is useful, better put that into the commit message. Then it'll show up automatically in the PR once you submit it and also will get recorded in the git history.

Having said that, the change is good. Thanks for taking the time to clean this up.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2019
@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2019

@pohly sure, will keep it in mind. Also updated in PR subject, so that it will be there in the commit history.

@jsafrane
Copy link
Contributor

jsafrane commented Jan 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1d5feb4 into kubernetes-csi:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants