Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for volume group snapshot #600

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add documentation for volume group snapshot #600

merged 2 commits into from
Jun 20, 2024

Conversation

leonardoce
Copy link
Contributor

@leonardoce leonardoce commented Jun 19, 2024 •
edited
Loading 

Improve the documentation to cover Volume Group Snapshots.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2024
xing-yang
xing-yang reviewed Jun 19, 2024
View reviewed changes
book/src/group-snapshot.md Outdated Show resolved Hide resolved
book/src/group-snapshot.md Outdated Show resolved Hide resolved
Madhu-1
Madhu-1 reviewed Jun 20, 2024
View reviewed changes
book/src/group-snapshot.md Outdated Show resolved Hide resolved
@leonardoce leonardoce force-pushed the doc_group_snapshot branch 2 times, most recently from 68044e0 to a4864ea Compare June 20, 2024 07:04
@leonardoce
Copy link
Contributor Author

I moved the group snapshot feature page inside the data sources section, where the snapshot feature is.
I should have addressed @xing-yang and @Madhu-1's comments too.
Thank you!

Madhu-1
Madhu-1 reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestions, @leonardoce can you please also add release-notes?

book/src/SUMMARY.md Outdated Show resolved Hide resolved
book/src/group-snapshot.md Outdated Show resolved Hide resolved
book/src/snapshot-restore-feature.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 20, 2024
@leonardoce
Copy link
Contributor Author

Thank you @Madhu-1. I added the release notes, too.

@leonardoce leonardoce requested a review from Madhu-1 June 20, 2024 08:37
@Madhu-1
Copy link
Contributor

Madhu-1 commented Jun 20, 2024

/lgtm
/assign @xing-yang

@leonardoce Thank you

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2024
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardoce, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1360f37 into kubernetes-csi:master Jun 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

@Madhu-1 Madhu-1 Awaiting requested review from Madhu-1

Assignees

@xing-yang xing-yang

@Madhu-1 Madhu-1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leonardoce @Madhu-1 @xing-yang @k8s-ci-robot