Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #81: connection: exit with less output on connection loss #112

Merged
merged 1 commit into from
May 5, 2022
Merged

Automated cherry pick of #81: connection: exit with less output on connection loss #112

merged 1 commit into from
May 5, 2022

Conversation

ialidzhikov
Copy link

@ialidzhikov ialidzhikov commented May 2, 2022 •
edited
Loading

/sig storage
/kind bug

Cherry pick of #81 on release-0.9.

#81: connection: exit with less output on connection loss

Part of kubernetes-csi/external-provisioner#732

Does this PR introduce a user-facing change?:

sidecars exit without output about goroutines when losing the connection to the driver

For details on the cherry pick process, see the cherry pick requests page.

@pohly @ialidzhikov
connection: exit with less output on connection loss
29f418d 
klog.Fatal dumps information about all running goroutines when the
connection to the CSI driver is lost. Loosing the connection is normal
and depends on the order in which containers are shut down. If it
happens, then the reason is unlikely to be related to goroutines.

Therefore this extra output is not helpful or worse, fills up logfiles
when a sidecar has many goroutines, as in the external-provisioner
which runs 100 workers by default.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2022
@k8s-ci-robot k8s-ci-robot requested review from pohly and saad-ali May 2, 2022 14:31
@k8s-ci-robot
Copy link
Contributor

Welcome @ialidzhikov!

It looks like this is your first PR to kubernetes-csi/csi-lib-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-lib-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 2, 2022
@pohly
Copy link
Contributor

pohly commented May 2, 2022

I wonder whether we really need to fork csi-lib-utils.

Can we update the older external-provisioner branches to the latest csi-lib-utils instead?

@ialidzhikov
Copy link
Author

Can we update the older external-provisioner branches to the latest csi-lib-utils instead?

Sure, this is also an option. I was not sure how backwards-compatible is updating minor versions of this library from 1 patch version to another one for a sidecar (for example external-provisioner). That's why the safer approach to me is to have v0.9.2 with this concrete patch. WDYT?

@pohly
Copy link
Contributor

pohly commented May 3, 2022

I looked at the changes in csi-lib-utils 0.10 and 0.11 and I think those are safe all the way back to release-2.1.

@ialidzhikov
Copy link
Author

Okay, then I will close this PR. Thanks!

/close

@k8s-ci-robot
Copy link
Contributor

@ialidzhikov: Closed this PR.

In response to this:

Okay, then I will close this PR. Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ialidzhikov
Copy link
Author

ialidzhikov commented May 4, 2022 •
edited
Loading

@pohly I quickly tried out. In short github.com/kubernetes-csi/csi-lib-utils@v0.10.0 has its K8s dependencies updated to v0.22.0. Trying to vendor github.com/kubernetes-csi/csi-lib-utils@v0.10.0 in external-provisioner@release-2.2 does a lot of changes under vendor:

$ git diff --shortstat
 193 files changed, 1923 insertions(+), 4620 deletions(-)

(dependencies like golang.org/x/net, golang.org/x/sys, google.golang.org/grpc get updated)

I would suggest to pick the approach with the cherry-pick and new patch release (github.com/kubernetes-csi/csi-lib-utils@v0.9.2). Looks cleaner and safer to me.

@ialidzhikov
Copy link
Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@ialidzhikov: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this May 4, 2022
pohly
pohly approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit bbda272 into kubernetes-csi:release-0.9 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@pohly pohly

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ialidzhikov @k8s-ci-robot @pohly