Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: runOnControlPlane chart config #882

Merged
merged 3 commits into from
Dec 11, 2024
Merged

fix: runOnControlPlane chart config #882

merged 3 commits into from
Dec 11, 2024

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: runOnControlPlane chart configuration

spec:
  nodeSelector:
    kubernetes.io/role: control-plane

Which issue(s) this PR fixes:

Fixes #861

Requirements:

Special notes for your reviewer:

Release note:

fix: runOnControlPlane chart config

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Dec 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2024
@coveralls
Copy link

coveralls commented Dec 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12257559632

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.784%
Totals Coverage Status
Change from base Build 12252975486: 0.0%
Covered Lines: 1034
Relevant Lines: 1296
💛 - Coveralls

@andyzhangx andyzhangx force-pushed the fix-runOnControlPlane branch from e6b8690 to b704e0d Compare December 10, 2024 09:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2024
@andyzhangx andyzhangx force-pushed the fix-runOnControlPlane branch from b704e0d to dc12f41 Compare December 10, 2024 09:38
@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2024
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit a8dbff5 into kubernetes-csi:master Dec 11, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runOnControlPlane/runOnMaster: true make the controller unschedulable
3 participants
@andyzhangx @k8s-ci-robot @coveralls