-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not use /var/lib/kubelet, use .Values.linux.kubelet instead #739
fix: do not use /var/lib/kubelet, use .Values.linux.kubelet instead #739
Conversation
Welcome @slaesh! |
Hi @slaesh. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@slaesh can you run following command, and push csi-driver-smb-v0.0.0.tgz changes? thanks.
|
/ok-to-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, slaesh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes an issues with using hardcoded
/var/lib/kubelet
instead of using the Values properly.Which issue(s) this PR fixes:
Fixes #639
Requirements:
Special notes for your reviewer:
hey there, after hours of fiddling around.. I found that there are still some hardcoded usages of
/var/lib/kubelet
.all of them should use the
.Values.linux.kubelet
I would assume. ;)So, after manually editing these values via Lens in my cluster.. everything works as expected! :))
Feel free to take over this PR or just fix it your way.. I have no idea how to edit these heml-charts properly..
Thanks and BR, Sascha ✌️
Release note: