Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add removeSMBMappingDuringUnmount config in chart config #527

Merged
merged 2 commits into from
Aug 17, 2022
Merged

feat: add removeSMBMappingDuringUnmount config in chart config #527

merged 2 commits into from
Aug 17, 2022

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 13, 2022 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add removeSMBMappingDuringUnmount config in chart config
related to #505

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: add removeSMBMappingDuringUnmount config in chart config

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2022
@coveralls
Copy link

coveralls commented Aug 13, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2859345842

  • 3 of 4 (75.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.46%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/fake_mounter.go 0 1 0.0%
Totals Coverage Status
Change from base Build 2852088421: 0.02%
Covered Lines: 817
Relevant Lines: 956
💛 - Coveralls

@andyzhangx andyzhangx force-pushed the removeSMBMappingDuringUnmount-switch branch 3 times, most recently from e767c59 to d300208 Compare August 14, 2022 11:44
@andyzhangx andyzhangx changed the title feat: add removeSMBMappingDuringUnmount in chart config feat: add removeSMBMappingDuringUnmount config in chart config Aug 14, 2022
@andyzhangx andyzhangx force-pushed the removeSMBMappingDuringUnmount-switch branch 5 times, most recently from bce9d74 to 4ff6228 Compare August 14, 2022 14:38
@andyzhangx
feat: add removeSMBMappingDuringUnmount in chart config
ae1d36e 
fix

fix ut

fix

fix

fix ut

fix win ut

fix

fix ut

fix
@andyzhangx andyzhangx force-pushed the removeSMBMappingDuringUnmount-switch branch from 4ff6228 to ae1d36e Compare August 14, 2022 14:54
@andyzhangx
Copy link
Member Author

cc @vitaliy-leschenko

@vitaliy-leschenko
Copy link
Contributor

Looks good. Maybe make sense to add the same option to deploy/csi-smb-node-windows.yaml for people who don't use helm?

@andyzhangx
Copy link
Member Author

Looks good. Maybe make sense to add the same option to deploy/csi-smb-node-windows.yaml for people who don't use helm?

@vitaliy-leschenko add in commit (05f9162), thanks.

@vitaliy-leschenko
Copy link
Contributor

@andyzhangx, Beautiful. This is more than I could wish for. When we can expect release 1.9.0?

@andyzhangx andyzhangx merged commit 999b3a2 into kubernetes-csi:master Aug 17, 2022
@andyzhangx
Copy link
Member Author

@andyzhangx, Beautiful. This is more than I could wish for. When we can expect release 1.9.0?

@vitaliy-leschenko will release 1.9.0 this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyzhangx @k8s-ci-robot @coveralls @vitaliy-leschenko