Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change dnsPolicy to Default and add dnsPolicy setting in chart #422

Merged
merged 1 commit into from
Mar 2, 2022
Merged

feat: change dnsPolicy to Default and add dnsPolicy setting in chart #422

merged 1 commit into from
Mar 2, 2022

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Feb 17, 2022 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
feat: change dnsPolicy to Default and add dnsPolicy setting in chart
original ClusterFirstWithHostNet is not suitable, may break with on-prem smb server when the SMB server is outside the K8s cluster

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: change dnsPolicy to Default and add dnsPolicy setting in chart

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022
@coveralls
Copy link

coveralls commented Feb 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1908087541

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.489%
Totals Coverage Status
Change from base Build 1907932321: 0.0%
Covered Lines: 760
Relevant Lines: 889
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2022
@andyzhangx andyzhangx changed the title fix: set dnsPolicy to Default feat: change dnsPolicy to Default and add dnsPolicy setting in chart Feb 27, 2022
@andyzhangx andyzhangx force-pushed the dnspolicy2 branch 2 times, most recently from 6e86901 to 1944cd9 Compare February 28, 2022 02:32
@andyzhangx andyzhangx merged commit 85fc248 into kubernetes-csi:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @coveralls