Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set "host is down" as corrupted mount #268

Merged
merged 2 commits into from
May 19, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented May 19, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: set "host is down" as corrupted mount
With this PR, if remove smb server is down, pod termination could still be completed.
port fix from kubernetes/kubernetes#101398

Which issue(s) this PR fixes:

Fixes #222, #164, #64

Requirements:

Special notes for your reviewer:

Release note:

fix: set "host is down" as corrupted mount

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 19, 2021 06:44
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021
@k8s-ci-robot k8s-ci-robot requested a review from ZeroMagic May 19, 2021 06:44
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2021
@coveralls
Copy link

coveralls commented May 19, 2021

Pull Request Test Coverage Report for Build 856097337

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.675%

Totals Coverage Status
Change from base Build 849838920: 0.0%
Covered Lines: 696
Relevant Lines: 803

💛 - Coveralls

@andyzhangx andyzhangx merged commit 302af1b into kubernetes-csi:master May 19, 2021
andyzhangx added a commit to andyzhangx/csi-driver-smb that referenced this pull request Dec 23, 2024
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild
119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1
0ae5e52d9 Update cloudbuild image with go 1.21+
406a79acf Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273d8 Set GOMODCACHE to avoid re-download toolchain
43bde065f Bump csi-sanity to 5.3.1

git-subtree-dir: release-tools
git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubPath unmount fails with "directory not empty" after smb-server Service IP changes
3 participants