Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish container linux and windows images in quay.io #16

Closed
andyzhangx opened this issue May 13, 2020 · 9 comments
Closed

publish container linux and windows images in quay.io #16

andyzhangx opened this issue May 13, 2020 · 9 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@andyzhangx
Copy link
Member

Is your feature request related to a problem?/Why is this needed

Describe the solution you'd like in detail

Currently docker files are under here:
https://github.com/kubernetes-csi/csi-driver-smb/blob/master/pkg/smbplugin/Dockerfile
https://github.com/kubernetes-csi/csi-driver-smb/blob/master/pkg/smbplugin/Windows.Dockerfile

could refer to:
https://github.com/kubernetes-csi/csi-driver-nfs/blob/master/release-tools/travis.yml

do you know how to do that? thanks
@wozniakjan

cc @jingxu97 @msau42

Describe alternatives you've considered

Additional context

@andyzhangx andyzhangx added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 13, 2020
@wozniakjan
Copy link
Member

hi @andyzhangx, the csi-release-tools repo contains very useful documentation on how to get started - https://github.com/kubernetes-csi/csi-release-tools/.

I am not entirely sure the tooling supports windows images too, tagging @pohly as he is much more knowledgeable point of contact with regards to the csi-release-tools.

@msau42
Copy link

msau42 commented May 13, 2020

We're trying to move our image publishing to the k8s-infra and @jingxu97 is working on getting Windows image building working there.

@andyzhangx
Copy link
Member Author

@jingxu97 do you know how can I publish the repo image to quay, it should support both windows and linux image. I am thinking whether it's appropriate to host the images on mcr.microsoft.com which I am quite familiar with.

@xing-yang
Copy link

@andyzhangx we are moving away from quay and publish images to the community infra. See issue opened here: kubernetes-csi/csi-release-tools#86

@pohly is in the process of making this change for all kubernetes-csi repos.

See this one for example: kubernetes-csi/csi-proxy#54

@pohly
Copy link

pohly commented Jun 3, 2020

https://github.com/kubernetes-csi/node-driver-registrar is successfully publishing multi-arch images that include Windows: https://console.cloud.google.com/gcr/images/k8s-staging-csi/GLOBAL/csi-node-driver-registrar?gcrImageListsize=30&gcrImageListsort=-uploaded

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 1, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants