Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added volumesnapshotclass to helm chart #826

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: added volumesnapshotclass to helm chart #826

merged 1 commit into from
Dec 18, 2024

Conversation

geoffrey1330
Copy link
Contributor

@geoffrey1330 geoffrey1330 commented Dec 18, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #825

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat: added volumesnapshotclass to helm chart

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 18, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 18, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: geoffrey1330 / name: Geoffrey Israel (7f5ab6c)

@k8s-ci-robot
Copy link
Contributor

Welcome @geoffrey1330!

It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @geoffrey1330. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2024
@andyzhangx
Copy link
Member

@geoffrey1330 thanks for the contribution, can you sign the cla and pls run helm package charts/latest/csi-driver-nfs -d charts/latest/ to update tgz file? thx

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 18, 2024
@geoffrey1330
Copy link
Contributor Author

helm package charts/latest/csi-driver-nfs -d charts/latest/

Sure

@andyzhangx
Copy link
Member

pls run git rebase -i HEAD~4 to squash all commits first

@geoffrey1330
Copy link
Contributor Author

pls run git rebase -i HEAD~4 to squash all commits first

Done

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 18, 2024
@andyzhangx
Copy link
Member 

Error: latest/csi-driver-nfs/templates/snapshotclass.yaml:6:47: [error] trailing spaces (trailing-spaces)
Error: latest/csi-driver-nfs/templates/snapshotclass.yaml:7:9: [error] too many spaces after colon (colons)
Error: latest/csi-driver-nfs/templates/snapshotclass.yaml:8:65: [error] trailing spaces (trailing-spaces)
make: *** [Makefile:60: verify] Error 1

@geoffrey1330
Copy link
Contributor Author 

Error: latest/csi-driver-nfs/templates/snapshotclass.yaml:6:47: [error] trailing spaces (trailing-spaces)
Error: latest/csi-driver-nfs/templates/snapshotclass.yaml:7:9: [error] too many spaces after colon (colons)
Error: latest/csi-driver-nfs/templates/snapshotclass.yaml:8:65: [error] trailing spaces (trailing-spaces)
make: *** [Makefile:60: verify] Error 1

fixed

@geoffrey1330
added volumesnapshotclass to helm chart
7f5ab6c 
removed duplicate deletionPolicy

made helm package update

added snapshotclass.yaml in deployer folder

added snapshotclass.yaml in deployer folder

Combined: Removed duplicate deletionPolicy, added snapshotclass.yaml, and updated helm package.

fixed merge conflict

added volumesnapshotclass to helm chart

updated helm value name for volumeSnapshotClass

updated helm value name for volumeSnapshotClass

added volumesnapshotclass to helm chart

format yaml file

added volumesnapshotclass to helm chart

made helm package update

added volumesnapshotclass to helm chart
andyzhangx
andyzhangx reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12392900225

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.566%
Totals Coverage Status
Change from base Build 12364997568: 0.0%
Covered Lines: 953
Relevant Lines: 1213
💛 - Coveralls

@k8s-ci-robot
Copy link
Contributor

@geoffrey1330: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-csi-driver-nfs-e2e-capz 7f5ab6c link false /test pull-csi-driver-nfs-e2e-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andyzhangx
Copy link
Member

/retest

andyzhangx
andyzhangx approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, geoffrey1330

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit e2ab583 into kubernetes-csi:master Dec 18, 2024
17 of 18 checks passed
@geoffrey1330 geoffrey1330 deleted the create_snapshotclass branch December 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@RaunakShah RaunakShah Awaiting requested review from RaunakShah

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Chart should create VolumeSnapshotClass as well.
4 participants
@geoffrey1330 @k8s-ci-robot @andyzhangx @coveralls