Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: show benchmark results for storage capacity tracking #350

Merged

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Mar 7, 2022

What type of PR is this?
/kind documentation

What this PR does / why we need it:

This was done in preparation for promoting storage capacity tracking to GA. The
csi-driver-hostpath repo seems like a suitable place to hold this text because
it showcases how to use the distributed deployment example.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2022
Comment on lines 281 to 283
There were other intermittent problems accessing the apiserver. Tweaking the
way how external-provisioner creates CSIStorageCapacity objects solved this
problem and the same test passed all three times that it was run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tweaks did you use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was meant to be a link to kubernetes-csi/external-provisioner#711. I just used the defaults from that updated external-provisioner - text updated.

@pohly pohly force-pushed the storage-capacity-experiment branch from d6d9639 to d117785 Compare March 7, 2022 18:07
@pohly
Copy link
Contributor Author

pohly commented Mar 7, 2022

/hold

Let me add results for 100 nodes with pods that have no volumes...

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2022
This was done in preparation for promoting storage capacity tracking to GA. The
csi-driver-hostpath repo seems like a suitable place to hold this text because
it showcases how to use the distributed deployment example.
@pohly
Copy link
Contributor Author

pohly commented Mar 7, 2022

/hold cancel

Baseline for 100 nodes was added.

The overhead for pods with volumes was actually slightly lower than it was for 10 nodes.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2022
@pohly pohly force-pushed the storage-capacity-experiment branch from d117785 to f053a7b Compare March 7, 2022 21:19
@jsafrane
Copy link
Contributor

jsafrane commented Mar 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@pohly
Copy link
Contributor Author

pohly commented Mar 8, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 053b05f into kubernetes-csi:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants