Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csi snapshotter sidecar image to 4.2.1 #325

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Aug 25, 2021

What type of PR is this?
/kind flake

What this PR does / why we need it:
This updates the CSI-Snapshotter sidecar image from v4.2.0 to v4.2.1.
Note that the CI test failure is from snapshot-controller images so we need kubernetes-csi/csi-release-tools#170 for the test to pass.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 25, 2021
@pohly
Copy link
Contributor

pohly commented Aug 25, 2021

Note that the CI test failure is from snapshot-controller images so we need kubernetes-csi/csi-release-tools#170 for the test to pass.

The test are failing because k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.1 cannot be pulled (latest published version is v4.2.0). What does that have to do with kubernetes-csi/csi-release-tools#170?

@xing-yang
Copy link
Contributor Author

/test ci-kubernetes-csi-canary-test-on-kubernetes-master

@k8s-ci-robot
Copy link
Contributor

@xing-yang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-1-19
  • /test pull-kubernetes-csi-csi-driver-host-path-1-20-on-kubernetes-1-20
  • /test pull-kubernetes-csi-csi-driver-host-path-unit
  • /test pull-kubernetes-csi-csi-driver-host-path-windows

The following commands are available to trigger optional jobs:

  • /test pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-master
  • /test pull-kubernetes-csi-csi-driver-host-path-1-20-on-kubernetes-master
  • /test pull-kubernetes-csi-csi-driver-host-path-1-21-on-kubernetes-1-21
  • /test pull-kubernetes-csi-csi-driver-host-path-1-21-on-kubernetes-master
  • /test pull-kubernetes-csi-csi-driver-host-path-alpha-1-20-on-kubernetes-1-20
  • /test pull-kubernetes-csi-csi-driver-host-path-1-19-test-on-kubernetes-1-19
  • /test pull-kubernetes-csi-csi-driver-host-path-1-19-test-on-kubernetes-master
  • /test pull-kubernetes-csi-csi-driver-host-path-1-20-test-on-kubernetes-1-20
  • /test pull-kubernetes-csi-csi-driver-host-path-1-20-test-on-kubernetes-master
  • /test pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-1-21
  • /test pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-master
  • /test pull-kubernetes-csi-csi-driver-host-path-alpha-1-20-test-on-kubernetes-1-20
  • /test pull-kubernetes-csi-csi-driver-host-distributed-on-kubernetes-1-21

Use /test all to run the following jobs that were automatically triggered:

  • pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-1-19
  • pull-kubernetes-csi-csi-driver-host-path-1-20-on-kubernetes-1-20
  • pull-kubernetes-csi-csi-driver-host-path-1-21-on-kubernetes-1-21
  • pull-kubernetes-csi-csi-driver-host-path-1-19-test-on-kubernetes-1-19
  • pull-kubernetes-csi-csi-driver-host-path-1-20-test-on-kubernetes-1-20
  • pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-1-21
  • pull-kubernetes-csi-csi-driver-host-path-unit
  • pull-kubernetes-csi-csi-driver-host-distributed-on-kubernetes-1-21

In response to this:

/test ci-kubernetes-csi-canary-test-on-kubernetes-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Contributor Author

Looks like only the snapshot-controller image was updated when I submitted this PR: kubernetes/k8s.io#2613
I'll need to update the images again.

@xing-yang
Copy link
Contributor Author

The test are failing because k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.1 cannot be pulled (latest published version is v4.2.0). What does that have to do with kubernetes-csi/csi-release-tools#170?

I was just trying to update the image to v4.2.1. The failure I'm talking about is referring to the flaky tests that 170 is trying to address, not related to this image issue.

@xing-yang
Copy link
Contributor Author

/retest

@pohly
Copy link
Contributor

pohly commented Aug 27, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 238ef8a into kubernetes-csi:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants