Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud build: initialize support for running commands in Dockerfile #182

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Jun 4, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:

The Dockerfile needs to run apk, which fails during the cloud build
with:
failed to solve: rpc error: code = Unknown desc = failed to load
LLB: runtime execution on platform linux/ppc64le not supported

The fix is described in https://github.com/multiarch/qemu-user-static#getting-started

Which issue(s) this PR fixes:
Related-to: kubernetes-csi/csi-release-tools#86

Special notes for your reviewer:

If this works, the if check will be moved into csi-release-tools/prow.sh and then become available also to other repos which need it (like some of the other CSI drivers).

Does this PR introduce a user-facing change?:

NONE

/cc @jsafrane

The Dockerfile needs to run apk, which fails during the cloud build
with:
  failed to solve: rpc error: code = Unknown desc = failed to load
  LLB: runtime execution on platform linux/ppc64le not supported

The fix is described in https://github.com/multiarch/qemu-user-static#getting-started
@k8s-ci-robot k8s-ci-robot requested a review from jsafrane June 4, 2020 06:45
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2020
@jsafrane
Copy link
Contributor

jsafrane commented Jun 4, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5915b62 into kubernetes-csi:master Jun 4, 2020
TerryHowe pushed a commit to TerryHowe/csi-driver-host-path that referenced this pull request Oct 17, 2024
…sion

Update csi-sanity test suite to v4.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants