Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick of #1073 to release-10.0: Fix python3 hang #1079

Merged
merged 4 commits into from
Feb 21, 2020
Merged

cherry-pick of #1073 to release-10.0: Fix python3 hang #1079

merged 4 commits into from
Feb 21, 2020

Conversation

fabianvf
Copy link
Contributor

@fabianvf fabianvf commented Feb 11, 2020 •
edited
Loading

Cleanup ThreadPool with atexit rather than del

(cherry picked from commit 0976d59)

Original PR: #1073

@k8s-ci-robot @fabianvf
Merge pull request kubernetes-client#1073 from fabianvf/fix-py3-hang
59f4bfd 
Cleanup ThreadPool with atexit rather than __del__

(cherry picked from commit 0976d59)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 11, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 11, 2020
@fabianvf
Copy link
Contributor Author

@roycaihw I'm not totally sure why CI is failing, it doesn't look related to these changes

@roycaihw
Copy link
Member

@fabianvf I think those tests failed because the new minikube cluster (newer k8s version) we test against doesn't support those APIs any more. You could cherrypick #888 and #966 to fix those tests

@k8s-ci-robot @fabianvf
Merge pull request kubernetes-client#888 from micw523/update-nginx
36f2129 
Deprecate extensions/v1beta1 deployment

(cherry picked from commit 41971cc)
@k8s-ci-robot @fabianvf
Merge pull request kubernetes-client#966 from micw523/testfix116
874d410 
Address API Changes Introduced in k8s v1.16

(cherry picked from commit c310289)
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2020
@roycaihw
Copy link
Member 

PyYAML requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*' but the running Python is 3.4.8

It looks like PyYAML has dropped 3.4 support. I think we can do the same for 10.0.2 #807

@fabianvf
Copy link
Contributor Author

@roycaihw ah, would you like me to revert that last commit then?

@roycaihw
Copy link
Member

@fabianvf I think yours is better.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9ca8780 into kubernetes-client:release-10.0 Feb 21, 2020
@tortila tortila mentioned this pull request May 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianvf @roycaihw @k8s-ci-robot