Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC authentication or error message about support authentication methods #368

Closed
briedel opened this issue Oct 18, 2017 · 9 comments
Closed
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@briedel
Copy link

briedel commented Oct 18, 2017

I was trying to use the python client against a kubernetes cluster that uses OIDC authentication. The python-client tried to log in as an "anonymous" user, which failed. It would be good to add OIDC authentication or add an error message that the authentication method was not support.

@mbohlool
Copy link
Contributor

mbohlool commented Oct 18, 2017

@mbohlool
Copy link
Contributor

kubernetes-client/python-base#31 is implementing this.

@briedel
Copy link
Author

briedel commented Oct 19, 2017

Thanks for the hint! I used the code from kubernetes-client/python-base#31 and found that there is a difference between how kubectl behaves and the python API. When a refresh token is necessary, kubectl does not require idp-certificate-authority-data to be set:

    if cfg[cfgCertificateAuthorityData] != "" {
        certAuthData, err = base64.StdEncoding.DecodeString(cfg[cfgCertificateAuthorityData])
        if err != nil {
            return nil, err
        }
    }

The error that is called seems to be suppressed somehow. Yet, with the same config the new oidc authentication requires idp-certificate-authority-data to be set:

ConfigException: Invalid kube-config file. Expected key idp-certificate-authority-data in kube-config/users[...]/user/auth-provider/config

There is a refresh-token URL provided in the config though, which might be what allows kubectl to get around the need for idp-certificate-authority-data

@lichen2013
Copy link

This issue is the same as #195

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 22, 2019
@benley
Copy link

benley commented May 26, 2019

It appears this may be addressed via kubernetes-client/python-base#48; should this issue be closed?

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants