-
Notifications
You must be signed in to change notification settings - Fork 183
Fixing get Google default credentials method #21
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 94.69% 94.19% -0.51%
==========================================
Files 9 9
Lines 698 706 +8
==========================================
+ Hits 661 665 +4
- Misses 37 41 +4
Continue to review full report at Codecov.
|
Yes, we need to fix this. I tried your fix and it almost worked, except it is taking a long time. The other fix is to run the |
I think we need to also write token back to kube config file. Can you please fix tests so we can merge this? |
I'm trying to fix tests, but I couldn't find what is wrong. Can you help me on how to run and identify what test has failed? Running the following:
Got:
|
run |
@gabrielgbim I sent a follow up PR for this to add expiration mechanism as well as persisting config. I will merge it after your PR. When you fixed tests here, can you review that PR? |
@gabrielgbim Are you going to fix this PR or I should go ahead with my other PR? |
@mbohlool You can go ahead with the other one. |
@gabrielgbim then you should probably close this one. Also it will be gret if you can test and review the other PR. Thanks for your time. |
Closing in favor of #22 |
This should fix the following error: