fix: remove dependency on net-keepalive #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node's net socket.setKeepAlive has an optional initial delay parameter. By setting this, it will request that the socket sends a TCP keep-alive probe every N milliseconds, removing the need for net-keepalive which is not portable. https://nodejs.org/api/net.html#net_socket_setkeepalive_enable_initialdelay Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bacongobbler, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Alabate
pushed a commit
to Alabate/kubernetes-client-javascript
that referenced
this pull request
Dec 28, 2024
This will send sends keep-alive probes to the server every 30 seconds. These features were present prior to the 1.0 refactor but were inadvertently removed. Fixes kubernetes-client#2127 Previous relevant issues: - Initial issue: kubernetes-client#559 - PR: kubernetes-client#630 - Improvement: kubernetes-client#632 - PR: kubernetes-client#635
Alabate
added a commit
to Alabate/kubernetes-client-javascript
that referenced
this pull request
Dec 28, 2024
This will send sends keep-alive probes to the server every 30 seconds. These features were present prior to the 1.0 refactor but were inadvertently removed. Fixes kubernetes-client#2127 Previous relevant issues: - Initial issue: kubernetes-client#559 - PR: kubernetes-client#630 - Improvement: kubernetes-client#632 - PR: kubernetes-client#635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node's net socket.setKeepAlive has an optional initial delay parameter. By setting this, it will request that the socket sends a TCP keep-alive probe every N milliseconds, removing the need for net-keepalive which is not portable.
https://nodejs.org/api/net.html#net_socket_setkeepalive_enable_initialdelay
fixes #632
Signed-off-by: Matthew Fisher matt.fisher@microsoft.com