Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openapi generator v4.2.3 #418

Conversation

sheldonkwok
Copy link
Contributor

@sheldonkwok sheldonkwok commented Feb 27, 2020

I was interested in adding a keepalive agent to the kubernetes clients requests.
This PR adds an "interceptor" model to the request options and it's in openapi generator v4.2.3.

In this PR, I have updated settings for this new openapi generator. I also changed the kubernetes-client/gen commit to one that uses node v10 since v8 is deprecated.

I ran the gen locally and it completed successfully but didn't include that since I wasn't sure if there were any other steps required.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2020
@sheldonkwok
Copy link
Contributor Author

/assign @brendandburns

@brendandburns
Copy link
Contributor

Please do run the gen locally and include that as a separate commit in this PR.

Thanks!

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2020
@sheldonkwok
Copy link
Contributor Author

Okay, pushed. I noticed the kubernetes/api/openapi-spec/swagger.json is now unversioned so everything is tagged with the branch name instead of the actual version. Is that okay now?

@ghost ghost mentioned this pull request Feb 28, 2020
@brendandburns
Copy link
Contributor

Do you have any idea why the tag changed? is it because of a change in the openapi generator?

I'd like to understand why that changed, and then we can merge this.

Thanks!

@sheldonkwok sheldonkwok force-pushed the feature/update-openapi-generator branch from 1d246c6 to 9fd4d76 Compare February 29, 2020 19:22
@sheldonkwok
Copy link
Contributor Author

Yeah in this commit the version was dropped from the openapi spec swagger.json
kubernetes/kubernetes@146d503#diff-9ce7ea8441086bf1902b4f936f4601d0

This seems to have been applied across multiple release branches. We were using branch release-1.15. In https://github.com/kubernetes-client/gen/blob/master/openapi/preprocess_spec.py#L379, unversioned specs end up taking on the branch/tag name so it became release-1.15. I just regenerated using the latest 1.15 tag (1.15.10). So now the file headers look more consistent. It seems like we should use the tag over the branch moving forwards.

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, sheldonkwok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit fe9bfd1 into kubernetes-client:master Mar 3, 2020
@simhnna simhnna mentioned this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants