-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openapi generator v4.2.3 #418
Update openapi generator v4.2.3 #418
Conversation
/assign @brendandburns |
Please do run the gen locally and include that as a separate commit in this PR. Thanks! |
Okay, pushed. I noticed the kubernetes/api/openapi-spec/swagger.json is now |
Do you have any idea why the tag changed? is it because of a change in the openapi generator? I'd like to understand why that changed, and then we can merge this. Thanks! |
1d246c6
to
9fd4d76
Compare
Yeah in this commit the version was dropped from the openapi spec swagger.json This seems to have been applied across multiple release branches. We were using branch |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, sheldonkwok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I was interested in adding a keepalive agent to the kubernetes clients requests.
This PR adds an "interceptor" model to the request options and it's in openapi generator v4.2.3.
In this PR, I have updated settings for this new openapi generator. I also changed the kubernetes-client/gen commit to one that uses node v10 since v8 is deprecated.
I ran the gen locally and it completed successfully but didn't include that since I wasn't sure if there were any other steps required.