Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KubernetesObjectSerializer::deserialize() should support list api #2125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thestupd
Copy link

  • Added a new KubernetesObjectList class to handle list APIs with appropriate schema attributes (apiVersion, kind, metadata, and items).
  • Updated the deserialization logic to instantiate and populate KubernetesObjectList instances when appropriate.
  • Added test cases to validate the deserialization of Kubernetes object lists, ensuring correctness and compatibility with unknown object schemas.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: empty21
Once this PR has been reviewed and has the lgtm label, please assign cjihrig for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

linux-foundation-easycla bot commented Dec 24, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @empty21!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 24, 2024
@thestupd
Copy link
Author

The custom Serializer update in version 0.22.0 for KubernetesObject, replacing ObjectSerializer, caused a breaking issue in my application. This is because the KubernetesObjectList case was not handled properly.

Example:

const responseList = await objectApi.list("foo", "bar", "default");
const firstItem = responseList.body.items[0];
// Modify some data
await objectApi.replace(firstItem); // This fails because the items in the list are not deserialized correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants