Initial add of proto-buffer files #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of these seem to follow /src/main/java/k8s/io, and others /src/main/java/io/kubernetes (the rest of the repo follow the later). Should we make them consistent? |
|
@lwander fixed (and fixed the generation script too...) Please take another look. |
|
Thanks! I don't think I can review much beyond that... so LGTM What's the plan for integrating this with the client library? |
|
@lwander good question! I need this library to start experimenting. If you'd prefer, I can wait to merge until I have the complete story, I'll branch off of this PR and keep exploring. |
|
I always like to merge sooner rather than later - feel free to merge whenever you feel ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbohlool @lwander
Uses kubernetes-client/gen#23