Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1 #63

Merged
merged 5 commits into from
Aug 11, 2017
Merged

Release 0.1 #63

merged 5 commits into from
Aug 11, 2017

Conversation

lwander
Copy link
Contributor

@lwander lwander commented Aug 11, 2017

Sorry for the churn, there were a few things left to fix

Non [maven-release-plugin] commits were written by me to get the release to pass.

Sonatypes validation of our artifacts has passed, I just need to update the JIRA ticket to indicate we've done our first release and the artifacts should be available after that.

@lwander
Copy link
Contributor Author

lwander commented Aug 11, 2017

Do we need to update the client capabilities badge?

@mbohlool
Copy link
Contributor

mbohlool commented Aug 11, 2017

So there are commits that cancel out changes from the previous commit? I see a lot of change 1.0-SNAPSHOT to 0.1-SNAPSHOT in one commit, then 0.1-SNAPSHOT to 0.1 in another commit then 0.1 to 0.2-SNAPSHOT in another one. Why is that? We probably need to create a release branch if we need those intermediate commits for the release process.

And yes, we can update client badge if we meet requirements for the next level.

@lwander
Copy link
Contributor Author

lwander commented Aug 11, 2017

The release branch has already been created: https://github.com/kubernetes-client/java/tree/release-0.1 (and is pointing at the next snapshot release).

The fact that our snapshot dependencies were sitting at 1.0 was incorrect. For the maven-release-plugin to publish the artifacts at version 0.1 they need to be checked it at version 0.1-SNAPSHOT - the plugin then automatically checked in a commit at version 0.1, released that, and revved the version to 0.2-SNAPSHOT.

Further development against master is under the assumption that we will either release 0.2 or 1.0 next. Patch changes are made against the branch I linked to above.

@mbohlool
Copy link
Contributor

mbohlool commented Aug 11, 2017

I see, it didn't realize those two PRs were created by the maven-release-plugin.

Non [maven-release-plugin] commits were written by me to get the release to pass.

completely missed this line :)

This looks good to me.

@mbohlool mbohlool merged commit fd07810 into kubernetes-client:master Aug 11, 2017
@lwander
Copy link
Contributor Author

lwander commented Aug 11, 2017

NP - thanks! The 0.1 release is complete :)

@lwander lwander deleted the release-0.1 branch August 11, 2017 23:02
@mbohlool
Copy link
Contributor

Nice. Thanks. Can you announce it on kubernetes dev mailing list?

@lwander
Copy link
Contributor Author

lwander commented Aug 11, 2017

My email should have gone out about an hour ago - kubernetes-dev @ googlegroups?

@mbohlool
Copy link
Contributor

mbohlool commented Aug 12, 2017 via email

@lwander
Copy link
Contributor Author

lwander commented Aug 12, 2017

Let's fix that with the next release

@lwander
Copy link
Contributor Author

lwander commented Aug 12, 2017

#64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants