Fix up some potential leaks, by calling close() #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
reviewed
Oct 28, 2017
| @@ -42,7 +42,7 @@ public static void main(String[] args) throws IOException, ApiException, Interru | |||
| Configuration.setDefaultApiClient(client); | |||
|
|
|||
| Attach attach = new Attach(); | |||
| final Attach.AttachResult result = attach.attach("default", "nginx-2371676037-czqx3", true); | |||
| final Attach.AttachResult result = attach.attach("default", "nginx-4217019353-k5sn9", true); | |||
There was a problem hiding this comment.
How useful is this pod name? Looks like it was generated by a deployment
There was a problem hiding this comment.
Well, this is example code :)
I could put "nginx-example-pod"
I suppose I could dynamically query and try to attach to the first pod I find, but I'm not sure how perfect an example needs to be. (I could also take the pod as a command line argument I suppose, but it seems like something for a different PR)
There was a problem hiding this comment.
Fair enough :) maybe we can revisit if someone files an issue but you're right, let's not complicate it
|
Will look and merge today. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apropos of #95
I audited the rest of our code...