Skip to content

Commit

Permalink
Domain name is not required when using application credentials (#154)
Browse files Browse the repository at this point in the history
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
  • Loading branch information
ahmedwaleedmalik authored Mar 18, 2022
1 parent a781ce3 commit 7500cde
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/cloudprovider/openstack/types/cloudconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ username = {{ .Global.Username | iniEscape }}
password = {{ .Global.Password | iniEscape }}
tenant-name = {{ .Global.ProjectName | iniEscape }}
tenant-id = {{ .Global.ProjectID | iniEscape }}
{{- end }}
domain-name = {{ .Global.DomainName | iniEscape }}
{{- end }}
region = {{ .Global.Region | iniEscape }}
[LoadBalancer]
Expand Down
1 change: 0 additions & 1 deletion pkg/cloudprovider/openstack/types/cloudconfig_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ func TestCloudConfigToString(t *testing.T) {
auth-url = "https://test"
application-credential-id = "redacted"
application-credential-secret = "redacted"
domain-name = "domain"
region = "unknown"
[LoadBalancer]
Expand Down

0 comments on commit 7500cde

Please sign in to comment.