Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet configuration Machine annotations #1135

Merged
merged 2 commits into from
Dec 19, 2021
Merged

Kubelet configuration Machine annotations #1135

merged 2 commits into from
Dec 19, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Dec 16, 2021

What this PR does / why we need it:
New v1.kubelet-config.machine-controller.kubermatic.io annotation.

To pass some kubeletConfiguraton custom values. Possible values are:

  • SystemReserved
  • KubeReserved
  • EvictionHard

If those found, serialized map will be used to populate corresponding KubeletConfiguraton field.

Special notes for your reviewer:
This is prerequisite for kubermatic/kubeone#1216

Optional Release Note:

Kubelet configuration Machine annotations

@kron4eg
New v1.kubelet-config.machine-controller.kubermatic.io annotation
eea575e 
To pass some kubeletConfiguraton custom values. Possible values are:
* SystemReserved
* KubeReserved
* EvictionHard

If those found, serialized map will be used to popualate corresponding
kubeletConfiguraton field.

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Update fixtures
5de6fe4 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2021
moadqassem
moadqassem approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 34a7b773f7b20ba2c038de5d7fb57df3ae84ba52

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 953f239 into kubermatic:master Dec 19, 2021
@kron4eg kron4eg deleted the kubelet-configs branch December 19, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadqassem moadqassem moadqassem approved these changes

Assignees

@moadqassem moadqassem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @moadqassem