Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign providerIDs to node objects that do not have a cloudprovider #564

Closed
alvaroaleman opened this issue Jun 6, 2019 · 18 comments
Closed

Assign providerIDs to node objects that do not have a cloudprovider #564

alvaroaleman opened this issue Jun 6, 2019 · 18 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.

Comments

@alvaroaleman
Copy link
Contributor

Currently, nodes on platforms that do not have a cloudprovider do not get their providerID property set. This will pose a problem for the cluster-autoscaler, which [identifies nodes by their providerID (https://github.com/frobware/autoscaler/blob/b4efe3c825bdeeae6b0155d8482ad1cf0e2a10f0/cluster-autoscaler/clusterstate/clusterstate.go#L947). If there are too many unindentified nodes, it will eventually just stop working.

Acceptance criteria:

  • We set the providerID on nodes and machines that do not have a cloud-provider
  • We do not set the providerID when an external cloud-provide is configured
@alvaroaleman alvaroaleman added the sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. label Jun 6, 2019
@alvaroaleman alvaroaleman mentioned this issue Jul 1, 2019
Merged
@kdomanski kdomanski added priority/low Not that important. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/low Not that important. labels Jul 19, 2019
@alvaroaleman alvaroaleman mentioned this issue Jul 31, 2019
Closed
@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2019
@kubermatic kubermatic deleted a comment from kubermatic-bot Aug 2, 2019
@alvaroaleman alvaroaleman removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2019
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2019
@kdomanski
Copy link
Contributor

/remove-lifecycle stale

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2019
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2020
@kdomanski kdomanski removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2020
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2020
@kubermatic-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubermatic-bot kubermatic-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 23, 2020
@kubermatic-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubermatic-bot
Copy link
Contributor

@kubermatic-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@unixfox
Copy link

unixfox commented Dec 6, 2020

Is it possible to reopen this issue? I just encountered it while having no cloud provider manager running.

I would like to use the autoscaler without using a cloud provider manager but due to the missing providerID I'm unable to do that.

@kron4eg
Copy link
Member

kron4eg commented Dec 6, 2020

@unixfox would you like to contribute this?

/reopen
/remove-lifecycle rotten

@kubermatic-bot
Copy link
Contributor

@kron4eg: Reopened this issue.

In response to this:

@unixfox would you like to contribute this?

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot reopened this Dec 6, 2020
@kubermatic-bot kubermatic-bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale. label Dec 6, 2020
@unixfox
Copy link

unixfox commented Dec 6, 2020

I'm not a Golang developer but I don't mind learning it. I'll try to work on it in January where I'll have a bunch of time to learn this new language and thus try to contribute for this new feature.

Meanwhile, thank you for reopening the issue.

@shaase-ctrl
Copy link

shaase-ctrl commented Feb 3, 2021 •
edited
Loading

Is there still interest in contributing? @unixfox

@unixfox
Copy link

unixfox commented Feb 3, 2021

Is there still interest in contributing? @unixfox

Yes but I don't have the time for that right now, and I'm not experimented enough in Golang yet.

You can close this issue if you really want to close it. That won't stop me from contributing later.

@shaase-ctrl
Copy link

Thanks for the heads up. I will move it to our icebox.

@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 8, 2021
@kubermatic-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubermatic-bot kubermatic-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 7, 2021
@kubermatic-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubermatic-bot
Copy link
Contributor

@kubermatic-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kron4eg @kdomanski @unixfox @alvaroaleman @kubermatic-bot @shaase-ctrl