Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RHEL support and update machine-controller to v1.14.2 #918

Merged
merged 9 commits into from
Jun 5, 2020
Merged

Add RHEL support and update machine-controller to v1.14.2 #918

merged 9 commits into from
Jun 5, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jun 3, 2020 •
edited by xmudrii
Loading

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #850

Special notes for your reviewer:
This change implements centos8/rhel8 support, but there the problem with machine-controller-webhook is still unresolved

Add RHEL support
Update machine-controller to v1.14.2
Add --force flag to kubeone install used to reinstall binaries (dangerous!)

kron4eg added 4 commits June 1, 2020 18:42
@kron4eg
new OS: kubeoneapi.OperatingSystemNameRHEL
5cce4a2 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg
New --force flag for kubeone install
e8ba045 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg
Reuse centOS / ubuntu templates for install / upgrade operations
2f68d95 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg
Regenerate testdata
c3dea07 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg kron4eg requested a review from xmudrii June 3, 2020 16:15
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 3, 2020
kron4eg added 4 commits June 4, 2020 09:59
@kron4eg
fix linter
8f29df8 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg
SELINUX=permissive
de54ee1 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg
update fixtures
3a50ea6 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg
Make it easy to change OS for both control plane and workers
0d9df62 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg
Copy link
Member Author

kron4eg commented Jun 4, 2020

/retest

@kron4eg
Upgrade machinecontroller to v1.14.2
e51e257 
as it contains important fix for RHEL8 at AWS

Signed-off-by: Artiom Diomin <artiom@loodse.com>
@xmudrii xmudrii changed the title RHEL support Add RHEL support and update machine-controller to v1.14.2 Jun 5, 2020
xmudrii
xmudrii approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Please create a follow-up issue for the machine-controller-webhook issue if there isn't one.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 20caf2b2a46da13cc72ddd246ad289c44eb4a122

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 3b39f37 into master Jun 5, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone Jun 5, 2020
@kubermatic-bot kubermatic-bot deleted the install-upgrade-scripts branch June 5, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Add RHEL support for master nodes
3 participants
@kron4eg @kubermatic-bot @xmudrii