Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v0.11] Bind the docker-ce-cli package, update machine-controller, and fix CoreOS scripts #907

Merged
merged 5 commits into from
May 21, 2020
Merged

[release/v0.11] Bind the docker-ce-cli package, update machine-controller, and fix CoreOS scripts #907

merged 5 commits into from
May 21, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 21, 2020

What this PR does / why we need it:

  • Bind docker-ce-cli to the same version as docker-ce
  • Fix CoreOS install and upgrade scripts
  • Update machine-controller to v1.11.3

Does this PR introduce a user-facing change?:

Bind `docker-ce-cli` to the same version as `docker-ce`.
Fix CoreOS install and upgrade scripts.
Update machine-controller to v1.11.3.

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg May 21, 2020 12:54
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 21, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8cd9da203e7bde01a6c07caaa264435b2f013960

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 725af586cc3210be8f272d40ad58bde808b5d639

@xmudrii xmudrii force-pushed the cherry-pick-docker-ce-cli branch from f65e3bd to 8e4d94d Compare May 21, 2020 13:16
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@xmudrii
Copy link
Member Author

xmudrii commented May 21, 2020

/retest

@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2c2b0adbd3df643506784ebbdbcd3d1a5971db1a

@kubermatic-bot kubermatic-bot merged commit 5f431ab into release/v0.11 May 21, 2020
@kubermatic-bot kubermatic-bot deleted the cherry-pick-docker-ce-cli branch May 21, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg