Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Untaint API Field to avoid default master taint #823

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Mar 13, 2020

What this PR does / why we need it:
In some usecases (i.e. at the edge) there is a need to init 1 or ever 3 nodes cluster, but only control-plane nodes without workers in a way that normal workloads would be allowed by default on the those nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #821

Does this PR introduce a user-facing change?:

New Untaint API field in config to remove default taints from control plane Nodes

@kron4eg kron4eg requested a review from xmudrii March 13, 2020 11:46
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 13, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2020
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the example config in pkg/cmd/config.go to add the new field?

@kron4eg
Copy link
Member Author

kron4eg commented Mar 13, 2020

@xmudrii done, along with rebase

Signed-off-by: Artiom Diomin <artiom@loodse.com>
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b72b06e0a2c55e86ba246fe0799797e69ec3fd5d

@kubermatic-bot kubermatic-bot merged commit 2dc663a into master Mar 13, 2020
@kubermatic-bot kubermatic-bot added this to the v0.12 milestone Mar 13, 2020
@kubermatic-bot kubermatic-bot deleted the 821-distaint branch March 13, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API flag to avoid control plane nodes tainted with NoSchedule
3 participants