-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bastion support #567
Bastion support #567
Conversation
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
* Always use hostnames provided by AWS * Generate hostnames for Azure Signed-off-by: Artiom Diomin <kron82@gmail.com>
/test pull-kubeone-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 94d44a77186ccf3c23aa34d2ffee9dbc04fd2d2f
|
What this PR does / why we need it:
Provides bastion support
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #337
Special notes for your reviewer:
Terraform config in aws-private requires pre-existing VPC provided via vars or alternatively var.subnet_offset/var.subnet_netmask_bits should be adjusted in order to avoid collision with existing subnets.