Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade machine-controller to v1.3.0 #499

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Upgrade machine-controller to v1.3.0 #499

merged 3 commits into from
Jun 18, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jun 18, 2019

What this PR does / why we need it:

* upgrade machine-controller to v1.3.0
* new labels field on hetzner
* don't hardcode `diskType` on AWS
* new (in kubeone) field `diskIops` on AWS
* new (in kubeone) field `network` to provide static network config
* new field `disableAutoUpdate`, CoreOS specific
* new field `disableLocksmithD`, CoreOS specific
* new field `disableUpdateEngine`, CoreOS specific

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2019
@xmudrii
Copy link
Member

xmudrii commented Jun 18, 2019

/hold

The E2E tests are currently not working.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2019
kron4eg added 3 commits June 18, 2019 15:06
@kron4eg
Add missing machinecontroller feature:
64d1166 
* static network configuration

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Add missing machinecontroller feature:
a7c1624 
* diskType
* diskIops
* remove hardcoded diskType

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Upgrade machinecontroller to v1.3.0
a3f1e68 
* Handle new field `labels` at hetzner
* Handle new fields `disableAutoUpdate`, `disableLocksmithD`, `disableUpdateEngine` on CoreOS

Signed-off-by: Artiom Diomin <kron82@gmail.com>
xmudrii
xmudrii approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cc388f481c448ed9b5d808a1bd7c10aa0dcd1136

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2019
@xmudrii
Copy link
Member

xmudrii commented Jun 18, 2019

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2019
@kubermatic-bot kubermatic-bot merged commit 300d413 into master Jun 18, 2019
@kubermatic-bot kubermatic-bot deleted the mc-130 branch June 18, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @xmudrii @kubermatic-bot