Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON tag for Name field #439

Merged
merged 2 commits into from
May 13, 2019
Merged

Fix JSON tag for Name field #439

merged 2 commits into from
May 13, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 13, 2019

What this PR does / why we need it:

Adds a JSON tag to the Name field.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #438

Release note:

Add JSON tag to the Name field

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg May 13, 2019 12:05
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2019
@xmudrii
Copy link
Member Author

xmudrii commented May 13, 2019

/cherrypick release/v0.6

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v0.6 in a new PR and assign it to you.

In response to this:

/cherrypick release/v0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/apis/kubeone/types.go Outdated Show resolved Hide resolved
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3606c21260dc807f330a9135bda2275a51f0cddd

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@kron4eg
Copy link
Member

kron4eg commented May 13, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit 532c39b into master May 13, 2019
@kubermatic-bot kubermatic-bot deleted the name-json branch May 13, 2019 13:07
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #441

In response to this:

/cherrypick release/v0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubeOneCluster object: name: Invalid value: "": no cluster name specified
3 participants