Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the KubeOneCluster API #353

Merged
merged 16 commits into from
Apr 19, 2019
Merged

Implement the KubeOneCluster API #353

merged 16 commits into from
Apr 19, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 15, 2019 •
edited
Loading

What this PR does / why we need it:

This PR implements the KubeOneCluster API. The API is similar to the old API, with some changes to improve the user experience.

Group name: kubeone.io
Kind: kubeonecluster

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #259

Special notes for your reviewer:

  • Consider using semver for versions instead of strings

Release note:

Implement the KubeOneCluster API

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 15, 2019
@kubermatic-bot kubermatic-bot added dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. and removed dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 15, 2019
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Apr 15, 2019
@xmudrii xmudrii force-pushed the cluster-api branch 4 times, most recently from 6b5d5d0 to 264e825 Compare April 17, 2019 13:01
@xmudrii xmudrii changed the title [WIP] Implement the KubeOneCluster API Implement the KubeOneCluster API Apr 17, 2019
@xmudrii xmudrii marked this pull request as ready for review April 17, 2019 13:02
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2019
@xmudrii xmudrii requested a review from kron4eg April 17, 2019 13:02
@xmudrii
Copy link
Member Author

xmudrii commented Apr 17, 2019

/assign @kron4eg

kron4eg
kron4eg requested changes Apr 18, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall sounds good

Gopkg.toml Show resolved Hide resolved
pkg/apis/kubeonecluster/doc.go Outdated Show resolved Hide resolved
pkg/apis/kubeonecluster/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeonecluster/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeonecluster/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeonecluster/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeonecluster/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeonecluster/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeonecluster/v1beta1/credentials.go Outdated
@@ -0,0 +1,115 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it intended that this file end-up in pkg/apis/kubeonecluster/v1beta1 instead of pkg/apis/kubeonecluster?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be moved

pkg/apis/kubeonecluster/validation/validation.go Outdated Show resolved Hide resolved
xmudrii added 9 commits April 19, 2019 09:32
@xmudrii
Add KubeOneCluster API types
37bd842 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Add API helpers
c9790b7 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Add v1beta1 API defaulting
61bc383 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Add internal API validation
f823457 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Add generated code
740eb5c 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Add generation scripts
99a6a6d 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Update Gopkg.* files
f36a37a 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Vendor dependencies
11c81e2 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Ignore vendored examples
b767bf8 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Ignore API lint errors
87dbd6f 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
xmudrii added 3 commits April 19, 2019 09:37
@xmudrii
Remove ObjectMeta from the API
afff7d2 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Address code review comments
cfddde2 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Run codegeneration
0513e67 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg April 19, 2019 11:30
xmudrii added 3 commits April 19, 2019 13:32
@xmudrii
Fix lint errors
e4e873a 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Update helper functions prefix
e8c8dfe 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Fix CI errors
08f8024 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Apr 19, 2019

/retest

kron4eg
kron4eg approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 336ed2580ce762d562ea860a02390848ca7f1de8

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@kubermatic-bot kubermatic-bot merged commit 7eb06f5 into master Apr 19, 2019
@kubermatic-bot kubermatic-bot deleted the cluster-api branch April 19, 2019 12:45
@xmudrii xmudrii mentioned this pull request Apr 19, 2019
Merged
@xmudrii xmudrii mentioned this pull request Apr 28, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg