Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh_username terraform variable #350

Merged
merged 1 commit into from
Apr 15, 2019
Merged

ssh_username terraform variable #350

merged 1 commit into from
Apr 15, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 15, 2019 •
edited
Loading

Fixes #349

ssh_username variable to be used in output in terraform examples

@kron4eg kron4eg requested a review from xmudrii April 15, 2019 07:52
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2019
xmudrii
xmudrii requested changes Apr 15, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this consistent across all providers we support.

examples/terraform/digitalocean/variables.tf Show resolved Hide resolved
@kron4eg
terraform variable ssh_username
3e3f1d7 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2019
@kron4eg kron4eg changed the title do ssh_user ssh_username terraform variable Apr 15, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Apr 15, 2019

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a04da14b8fdfbd4acbe537de5d0326ebfcff7fb

@xmudrii
Copy link
Member

xmudrii commented Apr 15, 2019

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Apr 15, 2019

/override pull-kubeone-e2e-digitalocean-conformance-1.13.5
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

DO API yet again doesn't feel good

@kubermatic-bot
Copy link
Contributor

@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-digitalocean-conformance-1.13.5, pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

In response to this:

/override pull-kubeone-e2e-digitalocean-conformance-1.13.5
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

DO API yet again doesn't feel good

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@kron4eg: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-digitalocean-conformance-1.13.5 3e3f1d7 link /test pull-kubeone-e2e-digitalocean-conformance-1.13.5
pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1 3e3f1d7 link /test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1
pull-kubeone-e2e-digitalocean-conformance-1.14.1 3e3f1d7 link /test pull-kubeone-e2e-digitalocean-conformance-1.14.1

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kron4eg
Copy link
Member Author

kron4eg commented Apr 15, 2019

/override pull-kubeone-e2e-digitalocean-conformance-1.14.1

@kubermatic-bot
Copy link
Contributor

@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-digitalocean-conformance-1.14.1

In response to this:

/override pull-kubeone-e2e-digitalocean-conformance-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 6222e1f into master Apr 15, 2019
@kubermatic-bot kubermatic-bot deleted the do_ssh_user branch April 15, 2019 11:32
@metalmatze
Copy link

Thanks! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use core as SSH user for CoreOS Container Linux
4 participants
@kron4eg @kubermatic-bot @xmudrii @metalmatze