Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.8] Add an option to disable Flatcar auto-upgrades #3393

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 24, 2024

What this PR does / why we need it:

Manual cherry-pick of #3391 and #3398

Which issue(s) this PR fixes:
xref #2320

What type of PR is this?
/kind flake

Special notes for your reviewer:

The purpose of this PR is to ensure we can use this improvement in the upgrade tests on the main branch.

Does this PR introduce a user-facing change? Then add your Release Note here:

Add `disable_auto_update` option to example Terraform configs for AWS, Azure, Equinix Metal, OpenStack, and vSphere, used to disable automatic updates for all Flatcar nodes

Documentation:

NONE

@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Sep 24, 2024
@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 24, 2024
@xmudrii xmudrii changed the title ]Add an option to disable Flatcar auto-upgrades [release/v1.8] Add an option to disable Flatcar auto-upgrades Sep 24, 2024
@xmudrii xmudrii marked this pull request as draft September 24, 2024 13:45
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 24, 2024
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii force-pushed the disable-flatcar-upgrades-1.8 branch from 363088d to b2497b9 Compare September 24, 2024 17:04
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 24, 2024
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
@xmudrii xmudrii marked this pull request as ready for review September 27, 2024 07:47
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2024
@xmudrii xmudrii requested a review from kron4eg September 27, 2024 07:47
@xmudrii
Copy link
Member Author

xmudrii commented Sep 27, 2024

/assign @kron4eg

@xmudrii
Copy link
Member Author

xmudrii commented Sep 27, 2024

/kind flake

@kubermatic-bot kubermatic-bot added kind/flake Categorizes issue or PR as related to a flaky test. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 27, 2024
@xmudrii xmudrii added the cherry-pick-approved Indicates a PR has been approved by release managers. label Sep 27, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 27, 2024
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii force-pushed the disable-flatcar-upgrades-1.8 branch from fddd39d to 2146cb5 Compare September 27, 2024 14:38
@xmudrii
Copy link
Member Author

xmudrii commented Sep 27, 2024

/retest

Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: beff9206a210da18b72a3509e3cf00170d97a0e3

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@kubermatic-bot kubermatic-bot merged commit 3aa836a into release/v1.8 Sep 27, 2024
14 checks passed
@kubermatic-bot kubermatic-bot deleted the disable-flatcar-upgrades-1.8 branch September 27, 2024 19:14
@xmudrii
Copy link
Member Author

xmudrii commented Dec 17, 2024

/remove-label flake
/kind feature

@kubermatic-bot kubermatic-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 17, 2024
@kubermatic-bot
Copy link
Contributor

@xmudrii: The label(s) /remove-label flake cannot be applied. These labels are supported: blocked by backend, merge-type/merge, merge-type/rebase, needs details, service accounts, Epic, MVP, customer-request, design, feature, proposal, ready-to-challenge, redesign, sig/api, sig/app-management, sig/cluster-management, sig/community, sig/infra, sig/networking, sig/ui, sig/virtualization, sprint, team/marketing, team/ps, lifecycle/frozen, backport-needed, backport-complete, ee, needs-release-testing, test/require-vsphere, test/require-kubevirt, test/require-vmwareclouddirector, test/require-nutanix. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label flake
/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xmudrii xmudrii removed the kind/flake Categorizes issue or PR as related to a flaky test. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants