Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.8] Allow upstream cluster autoscaler flags configuration #3306

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[release/v1.8] Allow upstream cluster autoscaler flags configuration #3306

merged 1 commit into from
Jul 17, 2024

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #3305

/assign kron4eg

Allow the configuration of the upstream cluster-autoscaler flags  `--enforce-node-group-min-size` and `--balance-similar-node-groups`

@archups
Allow upstream cluster autoscaler flags configuration
faa7d68 
Signed-off-by: archups <archupsawant@gmail.com>
@kubermatic-bot kubermatic-bot mentioned this pull request Jul 16, 2024
Merged
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Jul 16, 2024
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2024
@archups archups requested review from kron4eg and xmudrii July 17, 2024 06:31
@archups
Copy link
Contributor

archups commented Jul 17, 2024

cc @kubermatic/sig-release-managers

@kron4eg
Copy link
Member

kron4eg commented Jul 17, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: 15eb37b712be99e610cacd50556459364cd52808

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@xrstf xrstf added the cherry-pick-approved Indicates a PR has been approved by release managers. label Jul 17, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 17, 2024
@kron4eg
Copy link
Member

kron4eg commented Jul 17, 2024

/kind feature

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 17, 2024
@kubermatic-bot kubermatic-bot merged commit a867838 into kubermatic:release/v1.8 Jul 17, 2024
14 checks passed
@kubermatic-bot kubermatic-bot deleted the cherry-pick-3305-to-release/v1.8 branch July 17, 2024 10:08
@archups archups mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@kubermatic-bot @archups @kron4eg @xrstf