Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't downgrade GCP CCM for v1.27 clusters #3282

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Don't downgrade GCP CCM for v1.27 clusters #3282

merged 1 commit into from
Jun 27, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jun 27, 2024

What this PR does / why we need it:

KubeOne 1.8.0 has used GCP CCM v28.2.1 for all (supported) Kubernetes versions including v1.27. We changed this with #3232 so that we deploy GCP CCM version corresponding to the Kubernetes version.

However, this means that KubeOne 1.8.1 will downgrade the GCP CCM to an older version (from v28.2.1 to v27.1.6) for Kubernetes 1.27 clusters. This can cause regressions, especially as GCP CCM v28.2.1 has more features and controllers than v27.1.6.

To avoid any risks associated with this, this PR proposes that we continue using GCP CCP v28.2.1 for Kubernetes v1.27 clusters as we were doing in KubeOne 1.8.0.

What type of PR is this?
/kind regression

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

/assign @kron4eg

@xmudrii
Don't downgrade GCP CCM for v1.27 clusters
5c06fe0 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. kind/regression Categorizes issue or PR as related to a regression from a prior release. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Jun 27, 2024

/test pull-kubeone-e2e-gce-default-install-containerd-external-v1.27.11

@xmudrii
Copy link
Member Author

xmudrii commented Jun 27, 2024

/cherrypick release/v1.8

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.8 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kron4eg
kron4eg approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca2521e4053d7eecd55f53872c6b35b16bb3c968

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@kubermatic-bot kubermatic-bot merged commit 83eea33 into main Jun 27, 2024
15 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone Jun 27, 2024
@kubermatic-bot kubermatic-bot deleted the upgrade-gce-ccm branch June 27, 2024 18:53
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3284

In response to this:

/cherrypick release/v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg